Repository navigation
Add the remote protocol's messages for syncing songs - #60
Merged
Merged
Conversation
The same messages Clementine's network remote adds for syncing songs to the phone: sync sources and manifests, whether songs and Internet nodes can be downloaded, the server id and encodable formats in Clementine's info, and play reports. Nothing uses them yet, and the app's protocol version stays as it is: they're only used with a Clementine that says it supports them. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01R2bAq6kZW6eyymkA3zsd4p
hatstand
force-pushed
the
claude/project-thread-wugi27-sync-messages
branch
from
October 28, 2026 14:00
e099c57 to
334f743
Compare
hatstand
enabled auto-merge (rebase)
October 28, 2026 14:03
ScreenshotsFrom run 40693954413, against a real Clementine. Left: main. Right: this pull request, light and dark.
Screens at a failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #59 (swift-protobuf 1.39.0), which has merged.
This brings in the messages Clementine's network remote added for syncing songs to the phone (clementine-player/Clementine#7630):
remotecontrolmessages.pb.swiftis regenerated from the new proto with protoc-gen-swift 1.39.0. The.protois the same file the Android client has in clementine-player/Android-Remote#360. It keeps this app's package and its protocol version, 21: the new messages are only used with a Clementine that says it supports them.Nothing uses the messages yet.
swift testinPackages/ClementineKit(134 tests) andscripts/build.shpass.Generated by Claude Code