Repository navigation
Conversation
ScreenshotsFrom run 40992294597, against a real Clementine. Left: main. Right: this pull request, light and dark.
Screens at a failure
|
The Only on Wi-Fi switch becomes Download over, as in the Android app: Wi-Fi only, Wi-Fi and mobile data, or any network. iOS doesn't tell apps when they're roaming, so where the Android app leaves out roaming, this leaves out Low Data Mode. Wi-Fi only means a network that's neither expensive nor constrained, so another phone's hotspot counts as mobile data. Until a choice is made, the old switch decides: Wi-Fi only if it was on, any network if not, so nobody's downloads change on upgrade. Release-note: Settings has a new Download over choice: Wi-Fi only, Wi-Fi and mobile data, or any network. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01R2bAq6kZW6eyymkA3zsd4p
Syncing didn't look at the network setting, so kept songs could come over mobile data, such as when Clementine is reached through a VPN. Sync now checks Download over before it starts, like the other downloads, and the Downloads screen says why when it doesn't. Mirrors the Android app's change. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01R2bAq6kZW6eyymkA3zsd4p
hatstand
force-pushed
the
claude/project-thread-wugi27-keep-playlists
branch
from
October 30, 2026 02:32
3fdf0dd to
0a9997e
Compare
hatstand
force-pushed
the
claude/project-thread-wugi27-sync-network
branch
from
October 30, 2026 02:32
944bcae to
9d00f4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #65 (the base, the top of the media sync stack) and #66 (Download over), whose commit comes just before this one's. Until they merge, review only the commit "Sync kept music only over the networks Download over allows". Mirrors Android-Remote#369.
Syncerignored the network setting, so kept songs could sync over mobile data, for example when Clementine is reached through a VPN. Per the media sync design, sync follows the same network setting as downloads:Syncer.runOnceasksnetworkAllows(settings.downloadNetwork)before it starts.AppModelsets that check fromNetworkMonitor(it defaults to allowing every network). When the network isn't allowed, the sync doesn't start andStatus.networkNotAllowedis set.doesntSyncOverANetworkDownloadOverDoesntAllow.Behind
TestingFeatureslike the rest of media sync, so there's no release note.Generated by Claude Code