Repository navigation
#43 - Give a code to the tasks, class name as service id - #44
Merged
Merged
Conversation
Propagate cleverage/process-bundle#91: the tasks are referenced in the process configurations by their code (task: <code>), prefixed by the bridge name. - GetTask: code cache_get; SetTask: code cache_set (cleverage.task tag). - The service id of each task is its class name (non-shared, public, container.private tag: direct access from the service container is deprecated since 2.3, private in 3.0). - The former ids cleverage_cache_process.task.get / .set are private aliases of the class names, deprecated since 2.3, removed in 3.0. - Extension tests: class name id, code tag, container.private tag, deprecated aliases. - Documentation: code on the task reference pages and template, the examples use task: <code> (cache and process-bundle tasks), index. - CHANGELOG. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #43: propagate cleverage/process-bundle#91 (PR cleverage/process-bundle#294) to this bridge. Deprecations introduced in 2.3, removal in 3.0.
Changes
cache_get(GetTask) andcache_set(SetTask),cleverage.tasktag, so that the tasks are referenced withtask: cache_get(process-bundle 5.4 or later, where referencing a task by itsserviceis deprecated).cleverage_cache_process.registry.adapterargument, as before). They stay public, but fetching them directly from the service container is deprecated since 2.3 ({ name: container.private, package: cleverage/cache-process-bundle, version: '2.3' }):Accessing the "…" service directly from the container is deprecated, use dependency injection instead.; private in 3.0. The references of the container (process-bundle task locator) use the private service, without deprecation.cleverage_cache_process.task.get/cleverage_cache_process.task.set(released since 1.0, private): deprecated aliases of the class names since 2.3 (The "cleverage_cache_process.task.get" service alias is deprecated, use the "cache_get" task code or the class name of the task instead. It will be removed in 3.0.), removed in 3.0. They stay private, as before. No other service definition of the bundle referenced them.index.md(codes, service ids, deprecations).Requirement not changed yet:
cleverage/process-bundlestays^5.0, because 5.4 is not released (Composer could not resolve^5.4, the CI would fail). The change is harmless with process-bundle ≤ 5.3 (thecleverage.tasktag is ignored there;container.privateand deprecated aliases are Symfony features). To raise to^5.4before releasing 2.3 (thetask:key of the documentation requires it).Checks
cleverage.taskcode andcontainer.privatetags, registry argument kept; former ids private aliases with their deprecation.CleverAgeCacheProcessExtensionTest(class name as id, non-shared, arguments, code, public +container.private, former ids private deprecated aliases with their message). Aftercomposer update: 60 tests OK, PHPStan, PHP-CS-Fixer, Rector OK,composer validate --strictOK.Requirements
Breaking changes
None: the former ids and the public access are only deprecated (2.3), removed in 3.0.
🤖 Generated with Claude Code