Skip to content

#43 - Give a code to the tasks, class name as service id - #44

Merged
njoubert-cleverage merged 1 commit into
mainfrom
43
Oct 15, 2026
Merged

njoubert-cleverage merged 1 commit into
mainfrom
43

Conversation

@njoubert-cleverage

Copy link
Copy Markdown
Member

Description

Fixes #43: propagate cleverage/process-bundle#91 (PR cleverage/process-bundle#294) to this bridge. Deprecations introduced in 2.3, removal in 3.0.

Changes

  • Codes: cache_get (GetTask) and cache_set (SetTask), cleverage.task tag, so that the tasks are referenced with task: cache_get (process-bundle 5.4 or later, where referencing a task by its service is deprecated).
  • Service ids: the class names, as in process-bundle (definitions non-shared, with the cleverage_cache_process.registry.adapter argument, as before). They stay public, but fetching them directly from the service container is deprecated since 2.3 ({ name: container.private, package: cleverage/cache-process-bundle, version: '2.3' }): Accessing the "…" service directly from the container is deprecated, use dependency injection instead.; private in 3.0. The references of the container (process-bundle task locator) use the private service, without deprecation.
  • Former ids cleverage_cache_process.task.get / cleverage_cache_process.task.set (released since 1.0, private): deprecated aliases of the class names since 2.3 (The "cleverage_cache_process.task.get" service alias is deprecated, use the "cache_get" task code or the class name of the task instead. It will be removed in 3.0.), removed in 3.0. They stay private, as before. No other service definition of the bundle referenced them.
  • Docs: the code on the reference page of each task (and in the template), all the examples use the codes (cache tasks and process-bundle tasks, 26 references in the reference pages and cookbooks); index.md (codes, service ids, deprecations).
  • CHANGELOG (Latest).

Requirement not changed yet: cleverage/process-bundle stays ^5.0, because 5.4 is not released (Composer could not resolve ^5.4, the CI would fail). The change is harmless with process-bundle ≤ 5.3 (the cleverage.task tag is ignored there; container.private and deprecated aliases are Symfony features). To raise to ^5.4 before releasing 2.3 (the task: key of the documentation requires it).

Checks

  • Container definitions checked after loading the extension: class name ids public, non-shared, cleverage.task code and container.private tags, registry argument kept; former ids private aliases with their deprecation.
  • Tests: CleverAgeCacheProcessExtensionTest (class name as id, non-shared, arguments, code, public + container.private, former ids private deprecated aliases with their message). After composer update: 60 tests OK, PHPStan, PHP-CS-Fixer, Rector OK, composer validate --strict OK.
  • Demo project check to be done separately.

Requirements

  • Documentation updates
    • Reference
    • Cookbooks
    • Changelog
  • Unit tests

Breaking changes

None: the former ids and the public access are only deprecated (2.3), removed in 3.0.

🤖 Generated with Claude Code

Propagate cleverage/process-bundle#91: the tasks are referenced in the
process configurations by their code (task: <code>), prefixed by the
bridge name.

- GetTask: code cache_get; SetTask: code cache_set (cleverage.task tag).
- The service id of each task is its class name (non-shared, public,
  container.private tag: direct access from the service container is
  deprecated since 2.3, private in 3.0).
- The former ids cleverage_cache_process.task.get / .set are private
  aliases of the class names, deprecated since 2.3, removed in 3.0.
- Extension tests: class name id, code tag, container.private tag,
  deprecated aliases.
- Documentation: code on the task reference pages and template, the
  examples use task: <code> (cache and process-bundle tasks), index.
- CHANGELOG.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@njoubert-cleverage
njoubert-cleverage merged commit 069b883 into main Oct 15, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Give a code to the tasks (process-bundle#91), class name as service id

1 participant