Repository navigation
#49 - Add a class alias to autowire the AdapterRegistry - #50
Merged
Merged
Conversation
The CleverAge\CacheProcessBundle\Registry\AdapterRegistry alias (private) targets the cleverage_cache_process.registry.adapter service, so that the registry can be autowired, e.g. in a custom cache task extending AbstractCacheTask declared by the default App\ resource of an application. The custom task example of the documentation no longer passes the registry explicitly. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #49: the adapter registry can be autowired by its class.
config/services/registry.yaml: new private aliasCleverAge\CacheProcessBundle\Registry\AdapterRegistry→cleverage_cache_process.registry.adapter(same approach as DependencyInjection: add FQCN aliases and autoconfiguration for TaskInterface and TransformerInterface process-bundle#272). The service id is unchanged.DeleteTaskexample is autowired (autowire: true,autoconfigure: true, or the defaultApp\:resource) instead of passing'@cleverage_cache_process.registry.adapter', which is still mentioned for the versions before 2.3.AdapterRegistry.Checks
61 tests OK (also with code coverage, as the CI: no risky test), PHPStan, PHP-CS-Fixer, Rector OK.
Requirements
Breaking changes
None: new alias, the
cleverage_cache_process.registry.adapterid is unchanged.🤖 Generated with Claude Code