Repository navigation
#51 - Use the PHP 8.3 to 8.5 functions through the Symfony polyfills, and configure Rector accordingly - #52
Merged
Merged
Conversation
…olyfills, and configure Rector accordingly - Require symfony/polyfill-php83, symfony/polyfill-php84 and symfony/polyfill-php85 (^1.33), as in cleverage/process-bundle#299 - Rector: withPhpVersion(PhpVersion::PHP_82), the minimum supported version (was PHP_85), and withPhpSets() without explicit version, which adds the PHP_POLYFILLS set; remove the redundant LevelSetList::UP_TO_PHP_82 - No Rector rule applies on the current code, no manual replacement applies - CONTRIBUTING: add a "PHP version" section - Update CHANGELOG Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51
Description
Same change as cleverage/process-bundle#299 (PR cleverage/process-bundle#300), for this bridge.
Changes
symfony/polyfill-php83,symfony/polyfill-php84andsymfony/polyfill-php85(^1.33).withPhpVersion(PhpVersion::PHP_82)(wasPHP_85, inconsistent withphp >=8.2),withPhpSets()without explicit version (adds Rector'sPHP_POLYFILLSset: the rules using a newer function apply when the matching polyfill is required), remove the redundantLevelSetList::UP_TO_PHP_82and itsuse.RegisterAdaptersPass::process()andCleverAgeCacheProcessExtension::findServices():foreachloops with side effects (method calls, file loading), not searches / any / all tests; the latter iterates aFinder(iterator, not an array).AdapterRegistry:array_key_exists()lookups by key, nothing forarray_find*().tests/CleverAgeCacheProcessBundleTest::testAdaptersPassIsRegistered():array_filter()+assertCount(1, ...)asserts that the pass is registered exactly once;array_any()would only check at least once (weaker assertion).reset()/current()/end()/key(),json_decode(),trim()orucfirst()call insrc/(thereset()matches in tests areProcessState::reset()).src/andtests/(nothing relied on a transitive polyfill).Checks
--prefer-lowest, PHP 8.2): OK (61 tests, 127 assertions),symfony/polyfill-php83,-php84and-php85installed.Requirements
Breaking changes
None: three new small dependencies (polyfills), no change of the minimum PHP version.
🤖 Generated with Claude Code