#52 - Give a code to the task, class name as service id

[njoubert-cleverage]

Description

Fixes #52: propagate cleverage/process-bundle#91 (PR cleverage/process-bundle#294) to this bridge. Deprecations introduced in 3.3, removal in 4.0.

Changes

• Code: rest_request (RequestTask), cleverage.task tag, so that the task is referenced with task: rest_request (process-bundle 5.4 or later, where referencing a task by its service is deprecated).
• Service id: the class name, as in process-bundle (definition non-shared, same arguments and monolog.logger tag as before). It stays public, but fetching it directly from the service container is deprecated since 3.3 ({ name: container.private, package: cleverage/rest-process-bundle, version: '3.3' }): Accessing the "…" service directly from the container is deprecated, use dependency injection instead.; private in 4.0. The references of the container (process-bundle task locator) use the private service, without deprecation.
• Former id cleverage_rest_process.task.request (released since 2.0, private): deprecated alias of the class name since 3.3 (The "cleverage_rest_process.task.request" service alias is deprecated, use the "rest_request" task code or the class name of the task instead. It will be removed in 4.0.), removed in 4.0. It stays private, as before.
• The client registry and the client services are unchanged.
• Docs: the code on the reference page of the task (and in the template), all the examples use the codes (rest and process-bundle tasks, 17 references in index.md, the RequestTask reference and both cookbooks); index.md (code, service id, deprecations).
• CHANGELOG (Latest).

Requirement not changed yet: cleverage/process-bundle stays ^5.0, because 5.4 is not released (Composer could not resolve ^5.4, the CI would fail). The change is harmless with process-bundle ≤ 5.3 (the cleverage.task tag is ignored there; container.private and deprecated aliases are Symfony features). To raise to ^5.4 before releasing 3.3 (the task: key of the documentation requires it).

Checks

• Tests: CleverAgeRestProcessExtensionTest (class name as id, non-shared, arguments, monolog.logger tag, code, public + container.private, former id private deprecated alias with its message). After composer update: 33 tests OK, PHPStan, PHP-CS-Fixer, Rector OK, composer validate --strict OK.
• Demo project check: to be done separately.

Requirements

• Documentation updates
  • Reference
  • Cookbooks
  • Changelog
• Unit tests

Breaking changes

None: the former id and the public access are only deprecated (3.3), removed in 4.0.

🤖 Generated with Claude Code