Repository navigation
chore(deps): update vulnerable development dependencies - #3557
Merged
Merged
Conversation
LGTM.com is shut down and GitHub code scanning ignores `// lgtm [...]` comments, so they suppress nothing (alerts clientIO#75, clientIO#76, clientIO#77 stay open). Co-Authored-By: Claude Opus 5.5 <[email protected]>
Clears 172 of the 406 open Dependabot alerts on the root manifests. All of them are development-only - no published package changes its runtime dependencies. - webpack 5.112.0, webpack-dev-server 5.2.7 in examples and joint-core; the examples still on webpack-dev-server 4 (no patched release) move to webpack-cli 6 / webpack-dev-server 5 - their configs only use `devServer.static`, which v5 keeps - rollup 4.64.12 (GHSA-mw96-cpmx-2vgc), @babel/core 7.29.6, requirejs 2.3.8, async 2.6.4, shelljs 0.8.5 - re-resolve vulnerable transitive packages within their existing ranges (`yarn up -R`) Not covered: Angular 19 (no patched 19.x release), and packages held back by old parents (`[email protected]`, `happy-dom@8`, `chokidar@2`, `copy-webpack-plugin@5`, `@angular-devkit` 19). The standalone `packages/joint-core/demo/*/yarn.lock` files are untouched. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
kumilingus
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clears most of the open Dependabot alerts and removes comments that no longer suppress anything. Only development dependencies change; no published package changes its runtime dependencies, so the changeset is empty.
chore(deps)commits):joint-coreand the webpack-based examplesanchors-ts,bezier-js,connection-points-ts,layout-msagl,offscreen-rendering) move to webpack-cli 6 and webpack-dev-server 5, because v4 has no patched release. Their configs only usedevServer.static, which v5 keeps.yarn up -R);expressandqsonce more after the first pass picked aqswith another advisory// lgtm [js/xss-through-dom]comments inV/index.mjsandutil.mjs. LGTM.com is shut down and GitHub code scanning ignores them, so they suppress nothing and the three alerts on those lines stay open.Note
The
CodeQLcheck reports 3 new alerts (#98, #99, #100). They are #75, #76 and #77 under new numbers, not new findings. Code scanning matches an alert to earlier ones by a hash of the flagged line's text, and removing the comment changes that text. After merging, #75–#77 close as fixed and #98–#100 stay open, so the count does not change. The alert is a false positive: the flagged sinks areappendChild(node)calls, which never parse text as HTML, and CodeQL treats the element returned by theattr()setter as if it were the attribute object the getter returns. Please dismiss #98–#100 as false positive.Motivation and Context
GitHub's dependency review of this branch against
masterreports 297 vulnerabilities fixed (7 critical, 81 high, 169 moderate, 40 low) and none introduced.Not covered, because each needs a major upgrade:
examples/angular-element-view-ts(Angular 19 has no patched 19.x release)[email protected]throughbrilliant-errors,happy-dom@8,chokidar@2,copy-webpack-plugin@5,@angular-devkit19packages/joint-core/demo/*/yarn.lockfilesMerge before the matching JointJS+ PR. Its lockfile already resolves these versions, so its CI install fails until this PR is on
master.Testing
@joint/core:yarn buildandgrunt test. All suites pass apart from two karma tests that also fail onmasteron Windows (util.breakText ellipsis,port labels label attributes).anchors-ts(webpack-dev-server 4 to 5),layout-msagl,dwdmandlayout-directed-graphbuild with webpack 5.112.0, and theanchors-tsdev server starts and serves the page.🤖 Generated with Claude Code