Repository navigation
chore(deps): upgrade puppeteer to 25 and grunt-contrib-qunit to 11 - #3567
Merged
Merged
Conversation
puppeteer 24.22.0 -> 25.16.0 in every package that runs browser tests (still one version, so CI downloads one browser). grunt-contrib-qunit 7.0.1 -> 11.0.0 depends on puppeteer 25 itself, which replaces the root resolution that held it at 24.22.0. - puppeteer.executablePath() is asynchronous now: the karma configs await it, and joint-core sets CHROME_BIN in a grunt task that runs before the karma tasks. - grunt-contrib-qunit 8+ expects a global QUnit: the requirejs test pages load QUnit with a script tag and define it as the 'qunit' module - the builds under test are still loaded through RequireJS. - Chrome launches with --use-mock-keychain, so macOS does not prompt for the keychain password.
# Conflicts: # yarn.lock
Geliogabalus
approved these changes
Oct 28, 2026
# Conflicts: # yarn.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the browser test tooling, clearing Dependabot alerts that puppeteer 24 held: extract-zip ×2 and basic-ftp (
@puppeteer/browsers3 no longer depends on them) and zod 3 (chromium-bidi now uses zod 4).puppeteer24.22.0→25.16.0in@joint/core,@joint/layout-directed-graph,@joint/layout-elk,@joint/layout-msagl,@joint/router-avoidand@joint/sanitize- still one version everywhere, so CI downloads one browser (chore: pin puppeteer to a single version for GHA #3419). Puppeteer 25 needs Node>=22.12.0; CI runs 22.14.0.grunt-contrib-qunit7.0.1→11.0.0. It depends on puppeteer^25itself, so the rootgrunt-contrib-qunit/puppeteerresolution is removed.Adaptations:
executablePath()is asynchronous in puppeteer 25. The fivekarma.conf.jsfiles export anasyncconfig function that awaits it (the karma CLI supports that).@joint/coreloads its karma config through grunt, synchronously - a newchrome-bingrunt task setsCHROME_BINand runs first intest:src.QUnit. The threerequirejs.htmlpages loadqunit.jswith a script tag (withautostartoff) and define it as thequnitmodule - the code under test, the built bundles, is still loaded through RequireJS.--use-mock-keychain, so macOS no longer asks for the login keychain password when a new browser build runs.Testing
All on Chrome 156 (puppeteer 25.16.0):
@joint/coreyarn test: mocha, karma geometry / vectorizer / joint (2179), qunit joint / vectorizer / geometry, TypeScript tests.yarn testin@joint/layout-directed-graph(22),@joint/layout-elk(105),@joint/layout-msagl(5),@joint/router-avoid(32),@joint/sanitize(106).