Repository navigation
Add Asn1IntegerRef::to_der_contents - #543
Merged
kornelski merged 1 commit intoOct 26, 2026
Merged
Conversation
|
✅ Approved — A small, correct safe wrapper that reuses the existing The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed📋 Code Quality: ✅ LGTMThe wrapper reuses the existing 📝 Documentation: ✅ LGTMThe doc comment and the Reviewed commit: |
TheJokr
approved these changes
Oct 26, 2026
Contributor
|
clanky review |
kornelski
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a safe wrapper around
i2c_ASN1_INTEGERusing the existingto_der!macro. It returns the integer's minimal signed two's-complement DER encoding, excluding the tag and length.Includes tests for zero, sign boundaries, and integers larger than 64 bits.