Repository navigation
feat: Add table-header Button variant and header button support to atomic table components - #5305
Draft
gethinwebster wants to merge 2 commits into
Draft
gethinwebster wants to merge 2 commits into
gethinwebster wants to merge 2 commits into
Conversation
gethinwebster
force-pushed
the
dev-v3-gethinw-button-table-header
branch
from
November 17, 2026 15:36
74d3ee8 to
e572596
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5305 +/- ##
=======================================
Coverage 97.87% 97.87%
=======================================
Files 1016 1016
Lines 32887 32905 +18
Branches 12199 12207 +8
=======================================
+ Hits 32187 32205 +18
Misses 660 660
Partials 40 40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gethinwebster
force-pushed
the
dev-v3-gethinw-button-table-header
branch
from
November 17, 2026 16:16
e572596 to
1787744
Compare
gethinwebster
force-pushed
the
dev-v3-gethinw-button-table-header
branch
from
November 17, 2026 16:25
1787744 to
f542129
Compare
…omic table components Adds `variant="table-header"` and an `iconEnd` slot to Button. A table-header button fills a column header, for example to sort the column, and shows a sort indicator and sort priority in `iconEnd`. TableHeaderCell accepts `disablePaddings="headerButton"` to leave the content padding to such a button. TableRoot leaves room for the first column's focus ring and shows the ring in its sticky header copy. The existing Table is unchanged.
gethinwebster
force-pushed
the
dev-v3-gethinw-button-table-header
branch
from
November 19, 2026 12:39
f542129 to
a2cac50
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
table-headervariant and aniconEndslot toButton, and lets the atomic table components host it. A table-header button fills a column header, for example to sort the column, and shows a sort indicator and the multi-column sort priority iniconEnd.The existing
Tableis not changed. Adopting the variant there is a follow-up, kept ondev-v3-gethinw-table-adopt-header-button.Buttonvariant="table-header";iconEndslot, alongsideiconAlign(a dev warning if both place content at the end); test utilfindIconEnd()TableHeaderCelldisablePaddings="headerButton"leaves the content padding to a table-header button, so its focus ring sits at the button's edgeTableRootgetWrapperInlineSize, soTableRootcan leave its scroller padding out of the track. The existingTabledoesn't pass it and measures exactly as beforetable-root/sorting(single and multi-column sort, Shift+click) andtable-root/sticky-headeruse the buttonExisting
Tablecode paths: no files undersrc/table/orpages/table/change, andInternalTableHeaderCellstamps the same classes for theTableas before.Related links, issue #, if available: #5269 (alternative approach, a separate component)
How has this been tested?
iconEnd, the header cell padding, the scroller measurement, the sticky copy ring and the new scrollbar option. The existingsrc/table,src/table-root,src/table-header-cell,src/button,src/button-dropdownand sticky scrollbar suites pass unmodified.Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.