Skip to content

revert: Revert more than 4 columns support for column layout and key-value pairs - #5329

Merged
vikaskale2722 merged 2 commits into
mainfrom
revert-support-more-than-4-columns
Nov 19, 2026
Merged

vikaskale2722 merged 2 commits into
mainfrom
revert-support-more-than-4-columns

Conversation

@vikaskale2722

@vikaskale2722 vikaskale2722 commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Description

Reverts the "more than 4 columns" support for both ColumnLayout and KeyValuePairs.

Reverts:

The two reverts are applied newest-first (#5081 then #5086) because both changes touched
src/__tests__/snapshot-tests/__snapshots__/documenter.test.ts.snap; this order avoids a conflict there.

What this restores

Related links, issue #, if available: #5086, #5081

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Nov 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.86%. Comparing base (ddb08ab) to head (f4ba7e4).

Files with missing lines Patch % Lines
src/column-layout/flexible-column-layout/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5329      +/-   ##
==========================================
- Coverage   97.87%   97.86%   -0.01%     
==========================================
  Files        1016     1016              
  Lines       32887    32890       +3     
  Branches    12199    12200       +1     
==========================================
+ Hits        32187    32189       +2     
- Misses        660      661       +1     
  Partials       40       40              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vikaskale2722

Copy link
Copy Markdown
Member Author

/override-visual-regression Revert removes the 4 added permutations per page, so the baseline has more permutations than this branch and the length assertion fails. No visual change to the remaining permutations.

@vikaskale2722
vikaskale2722 removed the request for review from pan-kot November 19, 2026 12:38
@mxschll
mxschll enabled auto-merge November 19, 2026 13:10
@amanabiy
amanabiy disabled auto-merge November 19, 2026 13:10
@vikaskale2722
vikaskale2722 added this pull request to the merge queue Nov 19, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 19, 2026
@vikaskale2722
vikaskale2722 added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 3651909 Nov 19, 2026
69 of 73 checks passed
@vikaskale2722
vikaskale2722 deleted the revert-support-more-than-4-columns branch November 19, 2026 14:16

This branch was successfully deployed

3 active deployments
dev-pages-react18 — f4ba7e4b Deployed Nov 19, 2026 by vikaskale2722 via deploy (React 18) / deploy #3401
dev-pages-react16 — f4ba7e4b Deployed Nov 19, 2026 by vikaskale2722 via deploy (React 16) / deploy #3401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants