Repository navigation
revert: Revert more than 4 columns support for column layout and key-value pairs - #5329
Merged
Merged
Conversation
added 2 commits
November 19, 2026 12:11
vikaskale2722
requested
a balanced review from Copilot
and removed request for
Copilot
November 19, 2026 11:19
ernst-dev
approved these changes
Nov 19, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5329 +/- ##
==========================================
- Coverage 97.87% 97.86% -0.01%
==========================================
Files 1016 1016
Lines 32887 32890 +3
Branches 12199 12200 +1
==========================================
+ Hits 32187 32189 +2
- Misses 660 661 +1
Partials 40 40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
/override-visual-regression Revert removes the 4 added permutations per page, so the baseline has more permutations than this branch and the length assertion fails. No visual change to the remaining permutations. |
vikaskale2722
enabled auto-merge
November 19, 2026 12:15
vikaskale2722
disabled auto-merge
November 19, 2026 12:35
vikaskale2722
enabled auto-merge
November 19, 2026 13:09
vikaskale2722
disabled auto-merge
November 19, 2026 13:09
mxschll
enabled auto-merge
November 19, 2026 13:10
amanabiy
disabled auto-merge
November 19, 2026 13:10
vikaskale2722
enabled auto-merge
November 19, 2026 13:14
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 19, 2026
vikaskale2722
enabled auto-merge
November 19, 2026 13:40
vikaskale2722
disabled auto-merge
November 19, 2026 13:40
vikaskale2722
enabled auto-merge
November 19, 2026 13:46
vikaskale2722
disabled auto-merge
November 19, 2026 13:47
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts the "more than 4 columns" support for both
ColumnLayoutandKeyValuePairs.Reverts:
feat: Added support for more than 4 columns for column-layout component(16758ddda)feat: Enabled support for more than 4 columns for key-value pair(ddb08abfd)The two reverts are applied newest-first (#5081 then #5086) because both changes touched
src/__tests__/snapshot-tests/__snapshots__/documenter.test.ts.snap; this order avoids a conflict there.What this restores
ColumnLayoutagain supports at most 4 columns unlessminColumnWidthis set, andMAX_SUPPORTED_COLUMNSplus its dev warning return. Note this also restores the warning added in chore: Add dev warning for ColumnLayout when more than 4 columns are … #5214, which feat: Added support for more than 4 columns for column-layout component #5086 had removed.
KeyValuePairsagain clampscolumnsto 4 and warns when a higher value is passed.columns,bordersandminColumnWidthdocumentation returns to its previous wording, with thedocumenter snapshot updated to match.
Related links, issue #, if available: #5086, #5081
How has this been tested?
npm run build: passesnpm run test:unit: passessrc/column-layout/andpages/column-layout/are identical to
2d9695ee9(the commit before feat: Added support for more than 4 columns for column-layout component #5086), andsrc/key-value-pairs/andpages/key-value-pairs/are identical toba0dd038f(the commit before feat: Enabled support for more than 4 columns for key-value pair #5081).Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.