Skip to content

chore: Add allowlisted /override-check command - #5330

Closed
vvaliyev wants to merge 1 commit into
mainfrom
ci/override-required-check
Closed

vvaliyev wants to merge 1 commit into
mainfrom
ci/override-required-check

Conversation

@vvaliyev

Copy link
Copy Markdown
Member

Description

Adds the "Override required check" workflow: a maintainer comments /override-check <check> <reason> on a PR to mark one allowlisted required check as passed for the PR head commit (also runnable from the Actions tab).

Allowlist, fixed in the workflow:

  • visual-regression: posts the existing visual-regression-override status and re-runs the failed deploy jobs, same as today.
  • codecov: posts success to codecov/patch and codecov/project directly. Known gap: a later Codecov upload for the same commit overwrites the override, so the command has to be posted again.

Any other check name is refused and nothing is posted. The override applies to one commit only; a new push needs a new override.

/override-visual-regression <reason> stays as a transition alias for /override-check visual-regression <reason>, to be removed later.

Replaces .github/workflows/visual-regression-override.yml. Adds issues: write so the workflow can reply when a command is refused.

Related links, issue #, if available: n/a

How has this been tested?

YAML parsed; the comment parsing and 140-character description cap tested locally in bash. Not run on GitHub yet: needs a real PR comment after merge (issue_comment workflows run from the default branch).

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@vvaliyev
vvaliyev requested a balanced review from Copilot November 19, 2026 14:04
@vvaliyev vvaliyev changed the title ci: Add allowlisted /override-check command chore: Add allowlisted /override-check command Nov 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Independent overrides share a canceling concurrency group, so a Codecov override can interrupt a visual-regression override before failed deploy jobs are rerun, leaving the required check red.

1 open issue
What changed in this PR

Replaces the visual-regression-only override workflow with an allowlisted command for overriding visual regression or Codecov checks on a single commit.

Changes:

  • Adds /override-check <check> <reason> and manual dispatch, while retaining /override-visual-regression as a transition alias.
  • Preserves visual regression reruns and adds direct Codecov status overrides, with permission checks and failure replies.
  • Updates documentation and workflow messages to describe the new command and Codecov overwrite limitation.
File Description
docs/​RUNNING_TESTS.md Documents both override options, permissions, and limitations.
.github/​workflows/​visual-regression.yml Updates the workflow path in an explanatory comment only.
.github/​workflows/​visual-regression-override.yml Removes the superseded visual-regression-only workflow.
.github/​workflows/​override-check.yml Adds command parsing, authorization, allowlisted status overrides, reruns, and failure replies.
.github/​workflows/​deploy.yml Updates failure messages to recommend the new command.

Review effort: Balanced

Comment thread .github/workflows/override-check.yml Resolved
Add the "Override required check" workflow
(.github/workflows/override-check.yml). A maintainer comments
`/override-check <check> <reason>` on a PR, or runs the workflow
manually with a check, commit SHA and reason, to mark one allowlisted
required check as passed for the PR head commit.

The allowlist is fixed in the workflow:
- visual-regression: posts a success status to
  visual-regression-override and re-runs the failed jobs of deploy.yml
  so the "Visual regression result" gate re-evaluates.
- codecov: posts success statuses to codecov/patch and codecov/project.
  A later Codecov upload for the same commit overwrites them.

Any other check name is refused and nothing is posted. The comment is
read only through an environment variable, the reason is reduced to one
line and the status description is capped at 140 characters. The
commenter must have write, maintain or admin access. On a refused
command the workflow replies on the PR with a link to the run.

`/override-visual-regression <reason>` is kept as a transition alias
for `/override-check visual-regression <reason>`.
@vvaliyev vvaliyev closed this Nov 19, 2026
@vvaliyev
vvaliyev force-pushed the ci/override-required-check branch from ff42944 to 8de3fdf Compare November 19, 2026 14:09
@vvaliyev

Copy link
Copy Markdown
Member Author

Re Copilot review on override-check.yml concurrency: cancel-in-progress is now false, so overrides for different checks on the same PR queue instead of canceling each other.

@vvaliyev

Copy link
Copy Markdown
Member Author

Superseded by #5331 (same change, rebuilt on current main).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants