Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Independent overrides share a canceling concurrency group, so a Codecov override can interrupt a visual-regression override before failed deploy jobs are rerun, leaving the required check red.
1 open issue
What changed in this PR
Replaces the visual-regression-only override workflow with an allowlisted command for overriding visual regression or Codecov checks on a single commit.
Changes:
- Adds
/override-check <check> <reason>and manual dispatch, while retaining/override-visual-regressionas a transition alias. - Preserves visual regression reruns and adds direct Codecov status overrides, with permission checks and failure replies.
- Updates documentation and workflow messages to describe the new command and Codecov overwrite limitation.
| File | Description |
|---|---|
docs/RUNNING_TESTS.md |
Documents both override options, permissions, and limitations. |
.github/workflows/visual-regression.yml |
Updates the workflow path in an explanatory comment only. |
.github/workflows/visual-regression-override.yml |
Removes the superseded visual-regression-only workflow. |
.github/workflows/override-check.yml |
Adds command parsing, authorization, allowlisted status overrides, reruns, and failure replies. |
.github/workflows/deploy.yml |
Updates failure messages to recommend the new command. |
Review effort: Balanced
Add the "Override required check" workflow (.github/workflows/override-check.yml). A maintainer comments `/override-check <check> <reason>` on a PR, or runs the workflow manually with a check, commit SHA and reason, to mark one allowlisted required check as passed for the PR head commit. The allowlist is fixed in the workflow: - visual-regression: posts a success status to visual-regression-override and re-runs the failed jobs of deploy.yml so the "Visual regression result" gate re-evaluates. - codecov: posts success statuses to codecov/patch and codecov/project. A later Codecov upload for the same commit overwrites them. Any other check name is refused and nothing is posted. The comment is read only through an environment variable, the reason is reduced to one line and the status description is capped at 140 characters. The commenter must have write, maintain or admin access. On a refused command the workflow replies on the PR with a link to the run. `/override-visual-regression <reason>` is kept as a transition alias for `/override-check visual-regression <reason>`.
vvaliyev
force-pushed
the
ci/override-required-check
branch
from
November 19, 2026 14:09
ff42944 to
8de3fdf
Compare
Member
Author
|
Re Copilot review on |
Member
Author
|
Superseded by #5331 (same change, rebuilt on current main). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adds the "Override required check" workflow: a maintainer comments
/override-check <check> <reason>on a PR to mark one allowlisted required check as passed for the PR head commit (also runnable from the Actions tab).Allowlist, fixed in the workflow:
visual-regression: posts the existingvisual-regression-overridestatus and re-runs the failed deploy jobs, same as today.codecov: posts success tocodecov/patchandcodecov/projectdirectly. Known gap: a later Codecov upload for the same commit overwrites the override, so the command has to be posted again.Any other check name is refused and nothing is posted. The override applies to one commit only; a new push needs a new override.
/override-visual-regression <reason>stays as a transition alias for/override-check visual-regression <reason>, to be removed later.Replaces
.github/workflows/visual-regression-override.yml. Addsissues: writeso the workflow can reply when a command is refused.Related links, issue #, if available: n/a
How has this been tested?
YAML parsed; the comment parsing and 140-character description cap tested locally in bash. Not run on GitHub yet: needs a real PR comment after merge (issue_comment workflows run from the default branch).
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.