Skip to content

chore: Add hasInlineLabel to input's analytics metatada - #5332

Open
jperals wants to merge 1 commit into
mainfrom
dev-v3-jotresse-analytics-inline-label
Open

jperals wants to merge 1 commit into
mainfrom
dev-v3-jotresse-analytics-inline-label

Conversation

@jperals

@jperals jperals commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Description

inlineLabelText was added to Input in #4956, but the component does not track its usage, unlike the other components which support this feature: select, multiselect and control group.

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jperals
jperals marked this pull request as ready for review November 19, 2026 15:48
@jperals
jperals requested a review from a team as a code owner November 19, 2026 15:48
@jperals
jperals requested review from georgylobko and removed request for a team November 19, 2026 15:48
@jperals jperals changed the title chore: Add to input's analytics metatada chore: Add hasInlineLabel to input's analytics metatada Nov 19, 2026
@codecov

codecov Bot commented Nov 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.86%. Comparing base (3651909) to head (38253fc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5332   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files        1016     1016           
  Lines       32890    32890           
  Branches    12200    12199    -1     
=======================================
  Hits        32189    32189           
- Misses        661      695   +34     
+ Partials       40        6   -34     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch was successfully deployed

3 active deployments
dev-pages-react18 — 38253fc4 Deployed Nov 19, 2026 by jperals via deploy (React 18) / deploy #3411
dev-pages-react16 — 38253fc4 Deployed Nov 19, 2026 by jperals via deploy (React 16) / deploy #3411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants