Repository navigation
feat: Add ariaRole property to tree view - #5333
Open
jorycunningham wants to merge 1 commit into
Open
jorycunningham wants to merge 1 commit into
jorycunningham wants to merge 1 commit into
Conversation
Adds `ariaRole` ('tree' | 'list', default 'tree') to TreeView.
- `tree` keeps the current tree widget semantics and keyboard navigation.
- `list` renders nested lists: no tree, treeitem or group roles, no
aria-expanded or aria-level on items, and no roving tabindex, so expand
toggles and item actions are in the normal tab order. The `list` and
`listitem` roles are set explicitly because Safari drops list semantics
from lists styled with `list-style: none`.
jorycunningham
requested review from
ernst-dev
and removed request for
a team
November 19, 2026 16:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ariaRole('tree' | 'list', default 'tree') to TreeView. Closes #5326treekeeps the current tree widget semantics and keyboard navigation.listrenders nested lists: no tree, treeitem or group roles, no aria-expanded or aria-level on items, and no roving tabindex, so expand toggles and item actions are in the normal tab order. Thelistandlistitemroles are set explicitly because Safari drops list semantics from lists styled withlist-style: none.Tested in demo page using a screen reader
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md._CONTRIBUTING.md._Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.