Repository navigation
Gate WaveStar split-step aggregates and retain pointwise gap - #605
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Pin the exact HDF5 and a compact 225 s MATLAB R2025b split-step trace from run 39153812298. The source HDF5 differs at floating-point precision from the previously bundled WaveStar HDF5, so the new portable test uses the artifact's exact file. Its 500 wave components match the published baseline component bank exactly.
The test independently advances the current physical WaveStar plant at 1 ms with the 50 ms sampled NMPC and source rate-boundary delay. It preserves the existing seven
<0.5%aggregate limits for full-duration motion, force, command, and PTO work. The largest local relative error is 0.2392% (requested-torque RMS). The strict pointwise autonomous gate still fails: pitch differs by 0.007289 rad against 0.0005 rad, and speed, stroke, force, and requested torque also exceed their unchanged limits. WaveStar remains qualified; no solver default, pointwise gate, or badge count changes.Verification
1 passedlocally on current master.1 passed, pointwise1 xfailedas expected.1 passed; maximum pitch gap 0.0002427 rad, speed gap 0.001438 rad/s, stroke gap 0.0484 mm, and force gap 0.00423 N. Source torque requests are supplied for this diagnostic.git diff --checkpass.Pointwise gap localization
A separate local rerun using the exact pinned HDF5 and phase bank found the first breach of the unchanged pitch gate at 17.55 s and pitch-speed gate at 17.80 s, shortly after NMPC activates at 15 s. The command gate first fails at 24.15 s and axial-force gate at 43.80 s. Before control starts, the maximum pitch gap is 4.29e-5 rad over 10–15 s. The mismatch grows under closed-loop feedback, rather than appearing as a late isolated failure. This diagnostic does not establish pointwise parity.