Repository navigation
Document nonportable RM3 End Stops work audit - #606
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result
The independently advanced public
WEC.run(..., solver="wecsim_ode45")RM3 End Stops case gives a 400 s total damper-work gap of 0.4307% on local ARM64 macOS, below the existing 0.7% limit. Two local 100 s windows already exceed that limit (0.7993% and 0.9021%). On the exact prior PR head, the full Linux x86 Python suite measured a 0.8246% total-work gap and failed the unchanged 0.7% gate in run 39369510668. Both environments used NumPy 2.5.4 and SciPy 1.18.1.This revision removes the attempted portable full-run gate and records the counterexample in
PARITY.mdand the case-status ledger. The existing independent 120 s motion gate remains. RM3 End Stops stays qualified; badges and the physical solver default do not change. No threshold was relaxed.Verification
4 passed.git diff --checkpass.