Repository navigation
Record OSWEC variable-yaw step sensitivity on both solvers - #607
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Record a full-duration physical-step diagnostic for the published OSWEC irregular passive-yaw case. The ledger and case-status row now state that both MATLAB and Python separate after heading events. Add a measured JSON record and a yaw/heading-event plot. The case remains
mixed_modes; badges and solver defaults are unchanged.Evidence
1.1e-15rad with identical heading choices.WEC.runat 0.0025 s passes the unchanged yaw, speed, torque, and work limits through 160 s, then fails at 250 and 600 s. Full-run yaw and PTO-work gaps against published MATLAB are0.1154rad and12.55%.0.07350rad and6.15%. Both implementations are step-sensitive on the full event-driven path.0.0006rad yaw-limit breaches occur at 142.93 s for MATLAB 0.01→0.005, 166.98 s for Python 0.0025 versus published MATLAB, and 167.73 s for Python 0.0025→0.00125.The inputs, hashes, limits, and window results are in
docs/evidence/oswec-variable-yaw-refinement.json; the plot is indocs/figures/oswec-variable-yaw-step-gap.png. The separate matched MATLAB 0.005→0.0025 s source audit is still running and will be evaluated independently. This PR makes no full-duration physical parity claim.Verification
python3 tools/render_parity_badge.py --checkgit diff --check; plot visually inspected