Repository navigation
Conversation
ade7f84 to
46838da
Compare
|
how emotionally attached are you to |
|
I only stumbled over it through the tool. It looked just like the smallest change. |
it is, that's true, but it's widely adopted and regularly updated. Also this is a beast of a PR :) |
Fill the operator settings from module-owned options structs via go-flagsfiller, so introducing a parameter only touches the options struct and the chart's env values: the flag and the environment binding hook up automatically. Keep the command-line flags so users can inspect the options. Signed-off-by: Fabian Wiesel <[email protected]>
The manager reads its settings from the environment, so drop the --flag=$(ENV_VAR) container arguments. Signed-off-by: Fabian Wiesel <[email protected]>
46838da to
5195e67
Compare
Merging this branch will decrease overall coverage
Coverage detailsCompared to commit f5172c4 (run #41086905849)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files:
|
Parse the operator configuration into module-owned options structs filled by
go-flagsfiller, so introducing a
parameter only touches the options struct and the chart's env values: the
flag and environment binding hook up automatically,
--helpdocuments them,and invalid values fail once at startup. The chart drops the
--flag=$(ENV_VAR)arguments in a separate, revertable commit.Existing tests are updated for the option wiring; no new tests.
Relates to #13.