Repository navigation
Conversation
fwiesel
force-pushed
the
chart-username-from-secret
branch
from
October 30, 2026 13:32
9504148 to
c8b7bf8
Compare
fwiesel
marked this pull request as ready for review
October 30, 2026 13:32
notandy
requested changes
Oct 30, 2026
fwiesel
force-pushed
the
chart-username-from-secret
branch
4 times, most recently
from
October 30, 2026 15:02
e9d34c0 to
25611d6
Compare
The password already comes from Vault; the username should not be a plain environment value either. Both keys live in data now, which is what secrets-injector resolves. Signed-off-by: Fabian Wiesel <[email protected]>
fwiesel
force-pushed
the
chart-username-from-secret
branch
from
October 30, 2026 15:09
25611d6 to
15ffcf8
Compare
notandy
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The password already comes from Vault; the username should not be a plain environment value either.
secret.serviceUsernamefalls back to the existingenv.osUsernamevalue, so current deployments are unaffected.