Repository navigation
fix: retry hibernate cleanup before deleting a CocoonSet - #64
Merged
Merged
Conversation
The successor half could not fail at base: a fresh CocoonSet has no restore intent, so the operator never probes the tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting a suspended CocoonSet during a registry probe or DELETE failure previously removed its finalizer anyway. The surviving
:hibernatetag could then restore the previous guest state into a new same-named Set, because VM names are stable across Set UIDs. The old Set's cleanup record was already gone, so normal retries and local snapshot GC could not finish the deletion.Return the hibernate cleanup error and keep the existing finalizer and VM-name record until a later reconcile succeeds. This completes the teardown intent from #5 and #61 using the existing queue and idempotent tag lookup.
:latestretention and its best-effort cleanup remain unchanged. Successful reconciliation adds no registry calls, scans, locks, or persisted fields; the production Go diff has zero net lines.Validation:
:latestcleanup.GOWORK=off make test: Linux/Darwin vet and the complete native Darwin race/coverage suite passed.GOWORK=off make lint: pinned golangci-lint v2.13.2, Linux and Darwin, zero issues.GOWORK=off make fmt-checkand ASL on Linux/Darwin passed.