Repository navigation
build: agent-sandbox at upstream main; docs: the warm-candidate grace flag, measured - #84
Merged
Merged
Conversation
From ce66bdc, 76 commits. In the two API packages this repository imports, the change is one new constant and comment or marker edits.
… at v1.0.5 Upstream made the claim controller's 2 s wait for a warm Sandbox's Pod IP a flag (agent-sandbox PR 1758, from our issue 1745). Measured on the two-node testbed at 2 s and 10 s, slow and fast node side: latency does not move, so the docs name the flag and keep the default. v1.0.5, the latest release, ran alongside main and behaves the same; the install lines move to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
go.mod:sigs.k8s.io/agent-sandboxfromce66bdcto upstreammainatfa39d57(76 commits). In the two API packages this repository imports (api/v1beta1,extensions/api/v1beta1) the change is one new constant,SandboxReasonReconcilerError, plus comment and marker edits. No code here changes.docs/performance.md: the claim controller's 2 s wait for a warm Sandbox's Pod IP is a flag upstream now,--sandbox-claim-warm-candidate-grace-period(agent-sandbox PR 1758, from our issue 1745; onmain, in no release up to v1.0.5). The section gains the measurement below and the guidance that follows from it: keep the default.docs/configuration.md,README.md: upstream install lines move from v1.0.3 to v1.0.5, the latest release; the flag is named with its default and release status.Measurement
Two 384-core hosts, one virtual node each, 150 warm microVMs per node, sandboxd v0.1.15, vk-sandbox v0.1.5. A
SandboxWarmPoolof 40, then 200SandboxClaims at create parallelism 20, timed from create toReady. 14 arms, interleaved, every arm at least twice; 200/200 claims Ready in each.fa39d57, 2 sfa39d57, 10 sfa39d57, 2 sfa39d57, 10 smainat the default, on both settings.Not measured: the L3 path. Its two CRDs differ between v1.0.3 and v1.0.5 by one printer column.
Gates
GOWORK=off:go mod tidy(no further diff),go buildandgo veton linux and darwin,make generate(no diff),aslon both GOOS,make lint(10 of 10 runs0 issues.),make fmt-check,helm lint,go test -race -count=1 ./...— all clean.Hot-path cost: none, no code changes.