Repository navigation
fix(chat): space the jump-to-bottom button twice the composer gap above the $ button - #1785
Merged
Merged
Conversation
…ve the $ button The button's bottom offset is now derived from the composer's gap between the field and the $ button (ChatInputDefaults.OutsideSpacing), so its edge sits twice that gap above the $ circle instead of a hard-coded 20dp above the bar.
github-actions
Bot
added
type: fix
The jump button now springs in and eases out on tokens in ChatAnimations, and its unread badge sits on the circle's edge at 45 degrees instead of floating at the bounding-box corner. The badge scales in after the button, and a rising count slides and bumps while a falling one crossfades.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jump-to-bottom button sat 35dp above the $ button, a hard-coded offset. It now sits twice the composer's field-to-$ gap above it. That gap is
ChatInputDefaults.OutsideSpacing(10dp), so the vertical gap is 20dp.The offset is computed from that constant, so changing the composer's spacing moves the jump button with it.
JumpToBottomTestasserts the 2× relationship.On a Pixel 10 emulator the field-to-$ gap measures 26px and the jump-to-$ gap 52px, with the keyboard down and up.