Repository navigation
fix(navbar): keep unselected tab glyphs and labels white - #1786
Merged
Merged
Conversation
Unselected tabs dimmed their glyph and label to 50%. iOS 27 paints unselected tab glyphs in the main text color, so the outline glyph and the indicator pill now carry the selection on their own. The photo slot keeps its own unselected state (node 9713:664).
#1783 made opening a chat wait on newestPageLoads().first { }. The test's relaxed ChatCoordinator returns a Flow that completes empty, so first threw NoSuchElementException and both tests failed on code/cash. Stub it with a MutableSharedFlow, as ChatOpenTranscriptTest does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unselected tabs drew their glyph and label at 50% alpha. They now stay fully white, matching iOS 27, which paints unselected tab glyphs in
textMain(TabBarBadgedIcon.glyphColor). The outline-vs-filled glyph and the indicator pill still mark the selected tab.The You tab's photo slot keeps its unselected state from node 9713:664: a thinner ring and half opacity, the same as iOS's
TabBarProfilePhoto.iOS: code-payments/code-ios-app#1073.