Repository navigation
fix(messenger): draw Forward as Reply's mirror, like iOS - #1801
Merged
Merged
Conversation
Material's Forward is a straight block arrow. iOS uses arrowshape.turn.up.right.fill, the mirror of its Reply arrow, and Material has no equivalent, so the action bar now draws Reply's path flipped across x = 12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selection bar's Forward action (#1784) used Material's
Forward, a straight block arrow. iOS draws Forward witharrowshape.turn.up.right.fill, the mirror of its Reply arrow, so the two apps showed different glyphs side by side with Reply.Material has no mirrored Reply, and
Shortcutis an outlined shape of a different weight.ChatTopBarnow draws its ownForwardArrow: Material Reply's path flipped across x = 12, auto-mirrored like Reply.