Repository navigation
fix(chat): name the users a join notice is about - #1090
Merged
Merged
Conversation
System messages showed only the server's fallback text, which names no one. Read SystemContent.user_joined (who joined, and who admitted them) into the message, keep it in two new nullable message columns, and word the notice from the chat's current profiles: "Ada joined the group", "Ada added Bob", "Ada added you", "You added Bob", "You joined the group". Until a named user's profile loads, the notice shows the fallback text and the profile is requested; the chat list preview does the same.
bmc08gt
added a commit
that referenced
this pull request
Oct 19, 2026
* origin/main: fix(chat): name the users a join notice is about (#1090)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Join notices on iOS show only the server's
fallback_text, which doesn't say who joined. Android names the users since code-payments/code-android-app#1804. This reads theuser_joinedfields that flipcash2-client-protocol 0.19.0 already carries (main is pinned to it, so there's no bump here) and words the notice the same way Android does: "Ada joined the group", "You joined the group", "Ada added Bob", "Ada added you", "You added Bob".ConversationMessage.Content.systemgains an optionalSystemEvent.user_joinedwith a validuser_idbecomes.userJoined(userID:admittedBy:). An unset type or invalid id leaves only the fallback text.systemUserIdandsystemAdmittedBy, soDatabase.schemaVersiongoes from 52 to 53.SystemNoticeStrings.text(for:fallbackText:selfID:nameOf:)picks the sentence. The transcript and the chat list's last-message line both use it. If a named user's profile hasn't loaded yet, the notice shows the fallback text until it does.unnamedLastMessageSenders.Tests: new
SystemNoticeStringsTests, plus cases inConversationModelMappingTests(proto mapping),ChatMessageMappingTests,ConversationControllerTests(list preview and profile requests) andDatabaseConversationsTests(column round-trip).