Repository navigation
Fix main build break: tucana 0.0.83 NodeValueExecutionResult schema - #461
Merged
Merged
Conversation
…ange tucana 0.0.83 wraps node result/parameter values in NodeValueExecutionResult (a oneof of RawValue/SubFlowFunctionResult) instead of a bare Value, and renamed NodeParameterNodeExecutionResult to NodeValueExecutionResult. Update result_trim.rs to construct/match the new oneof shape. Co-Authored-By: Claude Sonnet 5 <[email protected]>
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/aquila/-/pipelines/3014404854 Status: Passed Job summariesdocs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/17643440315/artifacts/out/index.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainfails to build (cargo build/cargo check --all-targets) becausetucanawas bumped to0.0.83(via renovate), which changed the proto schema: noderesult/parameter_resultsvalues are now wrapped inNodeValueExecutionResult(a oneof ofRawValue(Value)/SubFlowFunctionResult) instead of a bareValue, andNodeParameterNodeExecutionResultwas renamed toNodeValueExecutionResult.src/sagittarius/test_execution_client_impl/result_trim.rsto construct/match the new oneof shape in both the production cut logic and its unit tests.Test plan
cargo check --all-targetscompiles cleancargo test— 61 passed, 0 failedcargo clippy --all-targets— no new warnings introduced🤖 Generated with Claude Code