Test JSON 2 and 3 in CI while retaining Ruby 2.7 support - #325
Merged
Merged
Conversation
Danger ReportNo issues found. |
|
coverage: 100.0%. remained the same — dblock:dblock/json-2-and-3 into codegram:master |
dblock
force-pushed
the
dblock/json-2-and-3
branch
4 times, most recently
from
October 4, 2026 14:07
5b6f6f0 to
060e8e4
Compare
Add JSON response parsing regressions and upgrade RuboCop to permit JSON 3. Keep Faraday unconstrained beyond its existing minimum; current releases fix JSON 3 keyword parser options. Co-authored-by: Copilot <[email protected]>
dblock
force-pushed
the
dblock/json-2-and-3
branch
from
October 4, 2026 14:07
060e8e4 to
f5081f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSON_VERSIONand document compatibility requirements.Root cause
The failure reported in #324 came from JSON 3 requiring keyword parser options while Faraday 2.14.3 passed a positional hash. Faraday 2.14.4 already fixes this upstream. Fresh CI bundles select that fix without changing the existing
faraday >= 2dependency or adding custom middleware. Older Faraday remains usable with JSON 2.Validation
Both JSON 2.21.2 and JSON 3.0.2 passed 159 unit tests and 32 Spinach steps on Ruby 3.3.5 with Faraday 2.14.4. RuboCop 1.91.0 passed. Verified the seven explicit CI entries.
Prepared by Copilot on behalf of @dblock.