Skip to content

Fix percentage advancement rounding - #93

Open
coder13 wants to merge 1 commit into
betafrom
fix/percentage-advancement-rounding
Open

coder13 wants to merge 1 commit into
betafrom
fix/percentage-advancement-rounding

Conversation

@coder13

@coder13 coder13 commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • round percentage-based advancement down to a whole competitor
  • add a regression test for 42 competitors with a top-75% cutoff
  • verify rank 31 advances while rank 32 does not

This fixes the incorrect advancement highlighting seen in Flex in Lex 2026, 3x3x3 Round 1, and keeps the computed cutoff compliant with WCA Regulation 9p1.

Validation

  • yarn test --runInBand — 37 suites, 170 tests passed
  • yarn check:type
  • yarn lint — no errors (4 existing warnings)
  • yarn build

@netlify

netlify Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for competition-groups ready!

Name Link
🔨 Latest commit 29ab2ee
🔍 Latest deploy log https://app.netlify.com/projects/competition-groups/deploys/6ad508d143409751d6680353
😎 Deploy Preview https://deploy-preview-93--competition-groups.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 59
Accessibility: 84
Best Practices: 100
SEO: 96
PWA: 90
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant