Repository navigation
💚 Separate primitive checks and stabilize cursor appearance test - #230
Merged
Merged
Conversation
codereport
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unrelated application failures currently prevent primitive comparisons from running. The cursor appearance test also races with overlay redraws and sometimes measures detached cursor elements as zero-width.
Run only
test:primitivesin Primitive Checks and movetest:appinto a separate Application Tests workflow with the same push, pull request, and manual triggers. Keepnpm testrunning both suites locally.Query and measure cursor elements in one synchronous
page.evaluate()call so a redraw cannot detach them between lookup and measurement.Validation:
npm run test:primitives: 97 passed, 23 skipped, 0 failed. The local APL server was unavailable.npm run test:app: 73 passed, 1 skipped, 0 failed. Dyalog is not installed locally.git diff --checkpasses.