Repository navigation
Conversation
Escape entity-like values in destinations and titles through the existing MarkdownWriter path so parsing the output preserves the AST values. Generated-by: OpenAI Codex
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendering a Link or Image whose destination/title contains literal entity-like text (for example
©orA) writes an unescaped ampersand. Parsing that Markdown again turns the text into a character, changing the AST value.For example:
Use the existing MarkdownWriter escaping for ampersands in bare/angle-bracket destinations and quoted titles. The regression tests cover links and images, named/decimal/hex entities, angle-bracket destinations, and ordinary ampersands. Ordinary query separators are also escaped in the Markdown output, while the parsed values stay the same; the renderer does not promise identical Markdown syntax.
Validation:
./mvnw clean verify javadoc:javadoc spotless:checksucceeds (4,603 test entries, 1 skipped, no failures/errors). Javadoc emits nonfatal missing siblingtarget/apidocslink messages; generation completes.AI disclosure: OpenAI Codex assisted with investigation, implementation, tests, and this description. The separate review was also performed by an AI session, not a human reviewer.