Repository navigation
fix: preserve disconnected conformance fixture responses - #23
Merged
Merged
Conversation
Signed-off-by: lucarlig <[email protected]>
lucarlig
marked this pull request as ready for review
October 29, 2026 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pinned TypeScript SDK 1.29.0 discards tool responses produced while their SSE stream is disconnected. A subsequent Last-Event-ID request cannot recover them. This makes header validation depend on which tool the gateway advertises first.
Persist resumable responses before checking for an active stream. Pin the fixture overlay to the affected SDK version and include it in packaged harness assets. Run three delayed reconnection checks in both legacy and dual fixture modes before publishing images. Prepare cf-integration 0.6.1.
The regression check times out against the original 0.6.0 fixture and passes six consecutive delayed reconnects against the corrected image, covering legacy and dual modes. Baseline generation and two subsequent fresh strict control-plane matrices complete. All eight comparisons pass with zero unexpected or stale findings. The regenerated baseline removes the obsolete legacy SSE polling timeout. Rust formatting, Clippy, all 431 Rust tests, 24 Python tests, workflow validation, and package asset inspection pass. CI passes on Linux, macOS, Windows, and both amd64 and arm64 image builds, including the reconnect smoke checks. One existing 20 ms reconciliation test required a serial suite run while the live Docker matrix was active.
Required by IBM/mcp-context-forge#7235.