Repository navigation
fix(telegram-subscriptions): delete unused fields - #103
Merged
Merged
Conversation
shoom3301
changed the title
shoom3301
commented
Oct 15, 2026
shoom3301
left a comment
shoom3301
left a comment
Contributor
Author
There was a problem hiding this comment.
✅ AI Review (Claude Opus 5.5, worked ~1m): no blocking findings; columns will be dropped on deploy (intended)
- Location:
src/api/telegram-subscription/content-types/telegram-subscription/schema.json - Strapi 4.26.1 defaults to
forceMigration: true, andconfig/databasedoesn't override it, so on deploy the schema sync dropsusername,first_nameandphoto_urlfromtelegram_subscriptions, along with their data. Confirmed as intended: this data doesn't need to be kept. - Custom endpoints (
getSubscriptions,getAccountSubscriptions,getAccountsByChatId) only selectid,account,chatId, so their responses don't change. linkViaBotstays compatible: a bot still sendingfirstName/usernamegets them ignored.
Note: [NITPICK] The PR title says "username", but 608eed2 also removes firstName and photoUrl. The existing approval was on ef1dfc9 (username only).
Generated using the pr-review skill from the CoW Protocol skills repo.
azebuado
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.