[francois-berder]

No description provided.

[firewave]

Please file a ticket for this.

[danmar]

Please file a ticket for this.

not sure if you have a trac account. let us know if you want us to file a ticket for you..

[francois-berder]

Please file a ticket for this.

not sure if you have a trac account. let us know if you want us to file a ticket for you..

Indeed, I do not have a trac account and I cannot create one myself so please file a ticket for me.

[chrchr-github]

Indeed, I do not have a trac account and I cannot create one myself so please file a ticket for me.

See https://trac.cppcheck.net/ticket/14660

[francois-berder]

Let me know if you want to squash the commits and include a reference to the ticket number in the commit message.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[chrchr-github]

Let me know if you want to squash the commits and include a reference to the ticket number in the commit message.

We always squash, and the PR title becomes the commit message, so it's all good.

[danmar]

hmm I feel it's out of scope for this PR but I feel the warning message is a bit obfuscated. The "leads to a dead code block" is true but it's an indirect consequence. I think it would be better to try to describe the direct consequence that inner condition s.empty() is always false.
I also feel that sometimes opposite inner conditions doesn't necessarily lead to dead code.. i.e.: if (x < 0 || s.empty()) I don't know if we warn but imho it should be OK to warn if the message is clear..