Repository navigation
Fix crash when closing one of several map views - #438
Merged
Merged
Conversation
The footprint scratch buffers were file-level statics shared by all GtkSatMap instances. Every new map reallocated them (leaking the old ones) and destroying any map freed them and set them to NULL, so the remaining maps segfaulted in calculate_footprint() on their next update, e.g. after closing one of two open copies of the same module. Make the buffers per-instance members of GtkSatMap.
Owner
|
Thanks for the patch. This was probably introduced while migrating to native GTK3/Cairo drawing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The footprint scratch buffers were file-level statics shared by all GtkSatMap instances. Every new map reallocated them (leaking the old ones) and destroying any map freed them and set them to NULL, so the remaining maps segfaulted in calculate_footprint() on their next update, e.g. after closing one of two open copies of the same module.
Make the buffers per-instance members of GtkSatMap.
replicate by open the module "Amateur" twice then close one of the two modules.