Repository navigation
fix(viewer): name the skincraft frame by aria-label, not title - #420
Merged
Merged
Conversation
A title on the iframe shows as a native tooltip when the modal opens under a resting cursor, and stays until the cursor moves into the frame. aria-label keeps the frame's accessible name without it.
Step7750
self-requested a review
October 14, 2026 17:33
Step7750
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
title="SkinCraft 3D viewer". When the modal opens under a resting cursor, Chrome shows that title as a native tooltip over the viewer until the cursor moves into the frame.aria-label, which keeps the frame's accessible name without the tooltip.Validation
npm run checkformatnpm run lintnpm testnpm run buildNote
Low Risk
Single accessibility attribute change on the viewer iframe with no behavior or security impact.
Overview
Replaces the SkinCraft embed iframe's
titlewitharia-labelso the frame still has an accessible name ("SkinCraft 3D viewer") without Chrome showing a persistent native tooltip when the modal opens under a stationary cursor.Reviewed by Cursor Bugbot for commit 0d0f76a. Bugbot is set up for automated code reviews on this repo. Configure here.