Skip to content

ci: read-only tokens for the test and docs workflows - #267

Open
youngnicks-cio wants to merge 1 commit into
mainfrom
ci/read-only-workflow-tokens
Open

youngnicks-cio wants to merge 1 commit into
mainfrom
ci/read-only-workflow-tokens

Conversation

@youngnicks-cio

Copy link
Copy Markdown

What: Gives the test and docs workflows the least token access they need.

  • main.yml (test): adds permissions: contents: read and persist-credentials: false on checkout. With no permissions block, push runs used the repo's default token, which is write.
  • docs.yml: the workflow is now contents: read, and pages: write and id-token: write move to the deploy job. The build job, which runs npm ci, no longer holds them. Checkout credentials are no longer persisted.

Why: Dependency install scripts run during npm ci, so those jobs should only have read access.

Tested: YAML validated locally. CI on this PR covers the test workflow. The docs change takes effect on the next push to main.

Deploy: None. Workflow-only change.

🤖 Generated with Claude Code

The test workflow had no permissions block, so push runs got the repo's
default write token, kept in the checkout while npm ci ran. Set it to
contents: read and stop persisting checkout credentials.

In docs, move pages: write and id-token: write from the whole workflow to
the deploy job, so the build job's npm ci runs read-only.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

@Shahroz16 Shahroz16 left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants