Repository navigation
ci: read-only tokens for the test and docs workflows - #267
Open
youngnicks-cio wants to merge 1 commit into
Open
youngnicks-cio wants to merge 1 commit into
youngnicks-cio wants to merge 1 commit into
Conversation
The test workflow had no permissions block, so push runs got the repo's default write token, kept in the checkout while npm ci ran. Set it to contents: read and stop persisting checkout credentials. In docs, move pages: write and id-token: write from the whole workflow to the deploy job, so the build job's npm ci runs read-only. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Gives the test and docs workflows the least token access they need.
main.yml(test): addspermissions: contents: readandpersist-credentials: falseon checkout. With no permissions block, push runs used the repo's default token, which is write.docs.yml: the workflow is nowcontents: read, andpages: writeandid-token: writemove to thedeployjob. The build job, which runsnpm ci, no longer holds them. Checkout credentials are no longer persisted.Why: Dependency install scripts run during
npm ci, so those jobs should only have read access.Tested: YAML validated locally. CI on this PR covers the test workflow. The docs change takes effect on the next push to main.
Deploy: None. Workflow-only change.
🤖 Generated with Claude Code