Repository navigation
Let ETH nodes choose Tor or clearnet - #1494
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pr1479/fix #1494 +/- ##
=============================================
Coverage ? 11.61%
=============================================
Files ? 1134
Lines ? 114182
Branches ? 0
=============================================
Hits ? 13263
Misses ? 100919
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
julian-CStack
approved these changes
Nov 3, 2026
The Tor/clearnet radios were hidden for Ethereum in d87af96 because web3dart could not be proxied at the time. Now that getEthClient honours the node's tor/clearnet flags and throws on a mismatch, a node stored as Tor-only or clearnet-only (older nodes, restored backups) could not be fixed from the node settings the error points the user to. Show the radios for ETH like every other coin.
julian-CStack
force-pushed
the
pr1479/eth-transport-controls
branch
from
November 3, 2026 00:36
6cdb2b0 to
827a13f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #1493. Set the base branch to
pr1479/fixso the diff shows only this commit; once #1493 merges GitHub retargets this PR to staging. Independent of the client guard PR, so the two can merge in either order.The Tor/clearnet radios in the add/edit node view were hidden for Ethereum in d87af96, when web3dart could not be proxied and the choice would have meant nothing. #1479 changes that:
getEthClientnow honours the node's tor/clearnet flags and throws a mismatch error that sends the user to node settings to fix the node. For ETH that page had nothing to fix it with. A node stored as Tor-only or clearnet-only (an older node, a restored backup, a node that keeps whatever the wallet saved before) could not be changed from the UI.This shows the radios for ETH exactly as for every other coin. One file, the six
if (widget.coin is! Ethereum)guards around the radio rows removed, nothing else in the form touched. A new ETH node still defaults to "Allow both", and existing nodes keep their saved flags.Verification
dart format --set-exit-if-changedclean on the changed filedart analyze lib test: no new lines versus stagingflutter test: all passed