Repository navigation
chore: upgrade SQL kernel to 1.3.0 - #518
Merged
Merged
Conversation
Signed-off-by: Vu Anh Phung <[email protected]>
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: 1 Nit
Looks good: this is a straightforward bump of the kernel bindings to v1.3.0. All seven platform modules move together, and the go.sum entries change consistently: the module zip h1: hashes are new, while the /go.mod hashes stay the same because those files didn't change. No stale v1.2.0 or old KERNEL_REV references remain outside the changelog history. The only note is a nit about changelog formatting.
Other findings
- ⚪ Nit — CHANGELOG.md: the new Unreleased bullet has a blank line after it, so it and the existing Go 1.27.3 bullet become a loose list. Recent sections (v1.17.0, v1.16.0) keep their bullets on consecutive lines. Remove the blank line to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade all seven platform binding modules to
v1.3.0and pin source builds to the published kernel commitd72c26492ad2fe2385b10eccd02e4ab462eec465. Add an Unreleased note.Validated
CGO_ENABLED=0 go test ./...andCGO_ENABLED=1 go test -tags databricks_kernel ./.... The existing C header matches all release archives.This PR was created with GitHub MCP.