Skip to content

CensusACS5YearSurvey_SubjectTables_S2408|Data Refresh - #2297

Open
Ashwani725 wants to merge 4 commits into
datacommonsorg:masterfrom
Ashwani725:s2408_table
Open

Ashwani725 wants to merge 4 commits into
datacommonsorg:masterfrom
Ashwani725:s2408_table

Conversation

@Ashwani725

@Ashwani725 Ashwani725 commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

CensusACS5YearSurvey_SubjectTables_S2408- 2024 observation year is fully ingested; all 15 historical years (2010 -2024) are present.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the US Census ACS 5-year subject table S2408 documentation to include data up to 2024 and modifies the pandas DataFrame processing in process.py to avoid using the deprecated inplace=True argument when replacing empty strings with NaN. Feedback suggests optimizing this replacement by performing it once outside the column loop where the place IDs are initialized, rather than repeatedly inside the loop.

Comment thread scripts/us_census/acs5yr/subject_tables/s2408/process.py
@Ashwani725
Ashwani725 requested a review from saanikaaa October 22, 2026 18:16
@Ashwani725 Ashwani725 self-assigned this Oct 22, 2026
@Ashwani725 Ashwani725 changed the title CensusACS5YearSurvey_SubjectTables_S2408 CensusACS5YearSurvey_SubjectTables_S2408|Data Refresh Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants