Repository navigation
CensusACS5YearSurvey_SubjectTables_S2408|Data Refresh - #2297
Open
Ashwani725 wants to merge 4 commits into
Open
Ashwani725 wants to merge 4 commits into
Ashwani725 wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the US Census ACS 5-year subject table S2408 documentation to include data up to 2024 and modifies the pandas DataFrame processing in process.py to avoid using the deprecated inplace=True argument when replacing empty strings with NaN. Feedback suggests optimizing this replacement by performing it once outside the column loop where the place IDs are initialized, rather than repeatedly inside the loop.
saanikaaa
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CensusACS5YearSurvey_SubjectTables_S2408- 2024 observation year is fully ingested; all 15 historical years (2010 -2024) are present.