Repository navigation
Conversation
Unannotated, strict type checkers (pyright strict) report every call to usaddress.tag as partially unknown.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
tag()leavestag_mappingunannotated in both__init__.pyand the new__init__.pyi, so pyright in strict mode reportsreportUnknownMemberTypeon everyusaddress.tag(...)call (its signature is(address_string: str, tag_mapping: Unknown | None = None)).This annotates it as
Optional[Mapping[str, str]], matching the docstring ({'OldTag': 'NewTag'}) and the body, which only calls.get()on it. No runtime change.Testing Instructions
mypy usaddressis cleanblack --check .is cleanpytest tests: 4972 passedstrict = true,usaddress.tag("123 Main St")no longer reportsreportUnknownMemberType