fix(windows): widen floating stats window instead of truncating values - #147
Merged
Merged
Conversation
Closes #145 Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Windows compilation and runtime validation are still needed for resizing, layout switching, and multi-monitor positioning.
Review effort: Balanced
Findings: None
What changed in this PR
Makes the Windows floating statistics window widen to show full values, addressing #145.
Changes:
- Sizes the window to content and keeps single-row columns equal.
- Preserves the right edge during resizing and clamps the window to the screen.
- Displays
1.0Mfrom 999,950 instead of1000.0k.
| File | Description |
|---|---|
| KeyStats.Windows/KeyStats/Views/FloatingStatsWindow.xaml.cs | Handles adaptive sizing and position preservation. |
| KeyStats.Windows/KeyStats/Views/FloatingStatsWindow.xaml | Removes truncation and enables content-sized width. |
| KeyStats.Windows/KeyStats/Services/StatsManager.cs | Adjusts the million-unit formatting threshold. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
123.4k）时被省略为12…。改为宽度随内容自适应，不再截断。1.0M，避免出现1000.0k。Closes #145
Changes
FloatingStatsWindow.xaml：SizeToContent="Width"，移除TextTrimming；单行布局两列改为Auto+SharedSizeGroup，保持等宽、分隔线居中。FloatingStatsWindow.xaml.cs：原固定宽度改为MinWidth（小数值时外观不变）；新增OnSizeChanged，窗口位于屏幕右半边时加宽保持右边缘不动，并重新 clamp/保存位置；位置计算改用ActualWidth。StatsManager.FormatNumber：M 单位阈值调整为 999,950。Test plan
12.3k不变宽，123.4k加宽且不截断，右边缘不动1.0M🤖 Generated with Claude Code