Repository navigation
Explain where auto deploy settings come from - #34
Merged
Merged
Conversation
Automatic deployments use deploy.yml from the default branch, manual ones from the branch being deployed. Recommend GitHub environment protection rules for production, since deploy.yml on a branch is not a security boundary. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01TyUrH6MzpSigq97F7hVEuX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Koen · project thread
Before: the
auto_deploy_ondocs didn't say which branch'sdeploy.ymlDeliverybot reads, or how to protect production.After: the docs say automatic deployments use
deploy.ymlfrom the default branch (so a branch's changes to an automatic target only apply once merged), manual deployments use the branch being deployed, and recommend GitHub environment protection rules for environments that matter.Why
Companion to deliverybot/deliverybot#171, which makes auto deploys build the deployment from the default-branch target instead of the pushed branch. Merge this once that PR is deployed. Anyone who can push a branch can also deploy it by hand, so
deploy.ymlisn't a security boundary and users should know where the real gate is.How
Two paragraphs added under
<target>.auto_deploy_onindocs/configuration.md.🤖 Generated with Claude Code
https://claude.ai/code/session_01TyUrH6MzpSigq97F7hVEuX
Generated by Claude Code