Repository navigation
fix(ci): stop warning about supported reusable patches - #651
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a4a4964. Configure here.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Retire the warning once reusable jobs can receive local changes.
What was happening
The CLI warned that reusable jobs would run without local changes, even when server support could apply their patch.
What happens now
Reusable calls retain their original YAML and send the patch key to the server. Ordinary jobs retain their existing patch step. A mixed-job regression covers the request and both job shapes.
Anything else
Release this after the API support in https://github.com/depot/api/pull/6303 is deployed. The local harness is in https://github.com/depot/api/pull/6304, and the documentation companion is https://github.com/depot/app/pull/4373.
Note
Low Risk
Small behavior change to CLI warnings and patch-step injection for reusable jobs; ordinary jobs unchanged and covered by a new integration test.
Overview
Removes the stderr warning that told users reusable workflow jobs would run without local patches, now that the CI API can apply workspace patches to those jobs via
WorkspacePatchCacheKey.In
injectPatchStep, jobs that only haveuses(nosteps) are treated as supported reusable calls and skip both patch injection and any message; the existing “has no steps” warning remains for other stepless jobs. AddsTestRun_reusableJobKeepsPatchKeyWithoutWarning, an end-to-end test that runs mixedbuild+ reusable jobs, asserts no reusable warning, patch upload, matching cache key on the run request, unchanged reusable YAML, and patch steps on the ordinary job.Reviewed by Cursor Bugbot for commit 6d7bbd8. Bugbot is set up for automated code reviews on this repo. Configure here.