Repository navigation
fix(codegen): open a blended decoration's stacking context on its backdrop owner - #123
Merged
owjs3901 merged 2 commits intoNov 10, 2026
Conversation
…kdrop owner A transparent wrapper inside a gradient owner received pos relative + zIndex 0 for its negative-z multiply decoration, so the decoration composited against transparency and drew white blobs (Prime contact banner, instance 32:1929). The context now lives on the nearest ancestor that paints the backdrop when the wrapper paints nothing and opens no context of its own and nothing in the ancestor is drawn before it. Unblended children, painting wrappers and earlier siblings keep the existing containment. Adds Rust regressions for the lift and its fallbacks, a harness browser pixel check with a control, and records 005/009 as resolved in the report. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
owjs3901
marked this pull request as ready for review
November 10, 2026 08:27
owjs3901
deleted the
devfive/3099154426bffbeef8b62999b80bb038/prime-feedback-followups
branch
November 10, 2026 08:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #121, which merged at 55409c7 before this commit was pushed. Fixes Prime feedback 005. The audit is in
reports/prime-feedback-2026-11.md→ "005 and 009 resolved".Problem
mix-blend-mode/filter/z-index/isolation/position/transformfaithfully; its Chromium screenshots are byte-identical to plain CSS. The defect is in devup-mcp codegen.pos="relative" zIndex="0"to the transparent content wrapper inside the gradient owner.multiplydecorations (zIndex="-1") therefore composited against a transparent backdrop and drew white blobs: center pixel 224,224,224 instead of 77,44,208.Change
codegen/layout/blend_backdrop.rs, called frompush_layout_props. The stacking context moves to the nearest ancestor that paints the backdrop when:pos="relative"for the decoration's coordinates.@devup-ui/wasm1.0.82 (devup-ui PR #681), with no MCP change.Test evidence
tests/blend_backdrop_context.rs: 4 regressions covering the lift onto the gradient owner (none on the wrapper) and the three fallbacks.harness/runtime-audit/test/codegen-layout.test.mjs): compiles the fixture with the installed Devup UI and checks:z-indexis0on the owner andautoon the wrapper;cargo fmt --all -- --checkandcargo clippy --locked --workspace --all-targets --all-features -- -D warnings: pass.cargo insta test --workspace --all-features --check: 2264 passed / 1 failed / 2 ignored locally on Windows. No snapshot or golden changed.r3_cancelled_client_recovers_retained_asset_job, a known load-dependent virtual-time test that fails only in the parallel full run (see fix: finish Prime feedback follow-ups (Korean wrap, heading margins, asset/theme/variant evidence) #121).composite_exportbinary passes 21/21.🤖 Generated with Claude Code
Submitted via Devfive hub. Employee: ; device:
3099154426bffbeef8b62999b80bb038