Skip to content

fix(go): keep project lint checks compatible with declared Go versions - #578

Merged
devantler merged 2 commits into
mainfrom
codex/go-linter-toolchain-577-01a131dd
Oct 12, 2026
Merged

devantler merged 2 commits into
mainfrom
codex/go-linter-toolchain-577-01a131dd

Conversation

@devantler

@devantler devantler commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

Shared validation currently rejects projects using the declared Go version before it can review their code, blocking delivery of the client portal.

What

Use compatible lint tooling and exercise the same Go version in the existing failure demonstration. Keep older projects supported and retain all existing quality requirements.

Part of #577

@github-code-quality

github-code-quality Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Code Coverage Overview

Languages: Go, C#

Go / code-coverage/test

The overall line coverage in commit a89f692 in the codex/go-linter-tool... branch remains at 50%, unchanged from commit 0ab32e7 in the main branch.

C# / code-coverage/dotnet

The overall line coverage in commit a89f692 in the codex/go-linter-tool... branch remains at 100%, unchanged from commit 0ab32e7 in the main branch.

Go / code-coverage/go

The overall line coverage in commit a89f692 in the codex/go-linter-tool... branch remains at 50%, unchanged from commit 0ab32e7 in the main branch.


Updated October 12, 2026 22:05 UTC

@devantler

devantler commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Validation at a89f692

Current base 0ab32e7; five changed files relative to that base; both branch commits signed and the published integration head GitHub-valid. After the earlier review, main advanced through #576. The fresh merge check caught this, and a normal signed integration preserved its native cache-observer contract and every existing quality requirement. No force push or code bypass was used.

The production, generated read-only and actual native negative fixture retain the same immutable lint-action SHA and bind compatible v2.14.0 tooling. Existing rules, scope and credential/failure boundaries remain unchanged. The PR deliberately says Part of #577: the legacy mirror, release and consumer proof remain outstanding, so merging this maintained slice must not prematurely close that issue.

  • The compatibility regression failed against the old binding before correction and passes afterward with six independently rejected substitutions. Pin parity, full credential/read-only projection parity, wiring controls, container toolchain controls, ShellCheck and all fourteen mandatory repository baselines pass. Local actionlint did not pass: this host's parser rejects existing native workflow fields; no parser warning was suppressed or presented as clearance.
  • Local actual v2.14.0 built with Go 1.27.2 reports the deliberate errcheck violation in the Go 1.27.2 fixture, and the unchanged older-Go healthy fixture passes.
  • Actual hosted CI 38311023437 at the earlier 510 head completed successfully. Its native Linux job 115017071153 installed the declared Go 1.27.2 and v2.14.0, produced the real errcheck finding, and verified that the failure was not operational. Clean/legacy and isolated PostgreSQL lint jobs also succeeded. These 243-job/277-check receipts remain historical at 510, not current-head clearance.
  • At the signed a89 integration, compatibility controls, tool-pin parity, full read-only projection/credential parity, current CI selection and catalogue-scope controls, and the merged main's native-cache observer controls pass locally. The actual new CI 38313587436 completed SUCCESS. Complete native current-head check read: 278/278, no failed or pending check; all thirteen exact-head workflows succeeded or were intentionally skipped. Earlier same-head body-edit bakes 38312596466/38312733799 were superseded before integration and are not relabeled as green.

The substantive Codex green 6133187497 reviewed 51086e6 and is stale after integration; it is preserved, never inherited. Ordered new-head progression: cr:no-gate@a89f692, reason=applicable included-review limit, NOT a verdict. The guard freshly returned ADMIT. New primary authenticated CodeRabbit limit, directly read at 22:11 UTC, states that all included free OSS reviews are used, with a 43-minute recovery from its 21:44:18Z event: not before 22:27:18Z. Its command refusal 6133164901 at 21:44:20Z corroborates that no review ran. This newer refusal supersedes both the older .github#576 timer and monorepo#4144's timer; the intervening served event is not ignored. Fresh review-lane health corroborates the limit and a serving Codex lane. Proceed under the new exact-head request lock, with no paid reviews, credit reset or Copilot.

Fresh complete read at this same a89 head confirms 244/244 actual CI jobs succeeded or were intentionally skipped, 278/278 native check runs with no failed or pending context, all thirteen exact-head workflow runs settled, and the CodeRabbit status successful but explicitly skipped (not a review). Current substantive Codex green 6133572151 explicitly reviews a89f692. Complete reviews and inline comments are empty, and all zero review threads were read with hasNextPage=false. The earlier 510 green is still stale; this new-head green is not inherited. No new provider is requested while it applies.

This remains validation evidence, not an independent review. Native configured code_quality completeness remains separately UNVERIFIED, never complete or waived. All readable required checks pass and GitHub currently reports CLEAN; normal protected exact-head promotion and merge remain mandatory, including any CI started by promotion.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T22:13:14.160183Z a89f692 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 51086e6957

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: a89f69278a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at a89f692

Current base: 0ab32e7. The five-file compatibility slice is tested, reviewed and exercised:

  • The old compiler binding failed the regression; the corrected binding passes with six independent negative controls. Existing rules, immutable action pin, scope, credentials and failure assertions remain intact. Current native CI 38313587436 completed successfully: all 244 jobs settled, and the complete 278 native checks have no failed or pending context. All thirteen current-head workflows are settled.
  • Current substantive Codex green 6133572151 explicitly reviews a89f692. Complete reviews, inline comments and all zero review threads reveal no actionable finding or unresolved thread. The previous 510 review is stale and is not reused.
  • As a workflow consumer, I ran the actual compatible tool against the Go 1.27.2 deliberate errcheck fixture and observed the real violation rather than an installation error; the unchanged older-Go healthy fixture passes. Hosted CI's actual Lint Gate Blocks job 115026027355 corroborates the changed failure boundary. Production/read-only projection parity and the merged base's native cache-observer tests pass. Local actionlint's unsupported existing workflow fields remain disclosed, not suppressed.
  • Fresh activity/holder reads find only this invocation's published a89 push and self-held worktree; no competing claim, human requirement, pending review or merge-group run. The published head has a GitHub-valid signature and GitHub reports CLEAN.

Configured native code_quality is separately UNVERIFIED, not complete or waived; all readable required checks pass. I will use only a normal protected exact-head merge, after any promotion-triggered CI settles. This maintained slice is Part of #577, not its end-to-end closure: frozen-legacy compatibility, release and consumer proof remain outstanding. No portal intake, payment, public-site publication or real-provider activation is enabled by this change.

@devantler
devantler marked this pull request as ready for review October 12, 2026 22:21
@devantler
devantler merged commit d3bd1ca into main Oct 12, 2026
283 checks passed
@devantler
devantler deleted the codex/go-linter-toolchain-577-01a131dd branch October 12, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant