Repository navigation
fix(go): keep project lint checks compatible with declared Go versions - #578
Conversation
Code Coverage OverviewLanguages: Go, C# Go / code-coverage/testThe overall line coverage in commit a89f692 in the C# / code-coverage/dotnetThe overall line coverage in commit a89f692 in the Go / code-coverage/goThe overall line coverage in commit a89f692 in the Updated |
Validation at a89f692Current base 0ab32e7; five changed files relative to that base; both branch commits signed and the published integration head GitHub-valid. After the earlier review, main advanced through #576. The fresh merge check caught this, and a normal signed integration preserved its native cache-observer contract and every existing quality requirement. No force push or code bypass was used. The production, generated read-only and actual native negative fixture retain the same immutable lint-action SHA and bind compatible v2.14.0 tooling. Existing rules, scope and credential/failure boundaries remain unchanged. The PR deliberately says Part of #577: the legacy mirror, release and consumer proof remain outstanding, so merging this maintained slice must not prematurely close that issue.
The substantive Codex green 6133187497 reviewed 51086e6 and is stale after integration; it is preserved, never inherited. Ordered new-head progression: cr:no-gate@a89f692, reason=applicable included-review limit, NOT a verdict. The guard freshly returned ADMIT. New primary authenticated CodeRabbit limit, directly read at 22:11 UTC, states that all included free OSS reviews are used, with a 43-minute recovery from its 21:44:18Z event: not before 22:27:18Z. Its command refusal 6133164901 at 21:44:20Z corroborates that no review ran. This newer refusal supersedes both the older .github#576 timer and monorepo#4144's timer; the intervening served event is not ignored. Fresh review-lane health corroborates the limit and a serving Codex lane. Proceed under the new exact-head request lock, with no paid reviews, credit reset or Copilot. Fresh complete read at this same a89 head confirms 244/244 actual CI jobs succeeded or were intentionally skipped, 278/278 native check runs with no failed or pending context, all thirteen exact-head workflow runs settled, and the CodeRabbit status successful but explicitly skipped (not a review). Current substantive Codex green 6133572151 explicitly reviews a89f692. Complete reviews and inline comments are empty, and all zero review threads were read with hasNextPage=false. The earlier 510 green is still stale; this new-head green is not inherited. No new provider is requested while it applies. This remains validation evidence, not an independent review. Native configured code_quality completeness remains separately UNVERIFIED, never complete or waived. All readable required checks pass and GitHub currently reports CLEAN; normal protected exact-head promotion and merge remain mandatory, including any CI started by promotion. |
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…hain-577-01a131dd
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Readiness at a89f692Current base: 0ab32e7. The five-file compatibility slice is tested, reviewed and exercised:
Configured native code_quality is separately UNVERIFIED, not complete or waived; all readable required checks pass. I will use only a normal protected exact-head merge, after any promotion-triggered CI settles. This maintained slice is Part of #577, not its end-to-end closure: frozen-legacy compatibility, release and consumer proof remain outstanding. No portal intake, payment, public-site publication or real-provider activation is enabled by this change. |
Why
Shared validation currently rejects projects using the declared Go version before it can review their code, blocking delivery of the client portal.
What
Use compatible lint tooling and exercise the same Go version in the existing failure demonstration. Keep older projects supported and retain all existing quality requirements.
Part of #577