Skip to content

fix(hub-ui): give dock iframes a title and the standalone hub landmarks #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erkamyaman wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(hub-ui): give dock iframes a title and the standalone hub landmarks #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d396dc6
fix(hub-ui): give dock iframes a title and the standalone hub landmarks
erkamyaman Oct 2, 2026
30be301
fix(hub-ui): localize the docks landmark label
erkamyaman Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/hub-ui/src/client/components/dock/DockStandalone.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<script setup lang="ts">
import type { DocksContext } from '@devframes/hub/client'
import { computed, useTemplateRef, watch } from 'vue'
import { t } from '../../i18n'
import { getEntryGroup } from '../../state/dock-settings'
import { getEntryPaneKey, useIframePanes } from '../../utils/useIframePanes'
import { useIsRpcTrusted } from '../../utils/useIsRpcTrusted'
Expand Down Expand Up @@ -55,11 +56,11 @@ function switchEntry(id: string | undefined) {

<template>
<ColorSchemeRoot>
<div v-if="!isRpcTrusted" class="h-screen w-screen of-hidden">
<main v-if="!isRpcTrusted" class="h-screen w-screen of-hidden">
<ViewBuiltinClientAuthNotice :context="context" />
</div>
</main>
<div v-else class="h-screen w-screen of-clip grid cols-[max-content_1fr]">
<div class="border-r border-base flex flex-col min-h-0">
<nav :aria-label="t('settings.docks')" class="border-r border-base flex flex-col min-h-0">
<div class="p2 border-b border-base flex">
<BrandMark class="w-7 h-7 ma" />
</div>
Expand All @@ -77,8 +78,8 @@ function switchEntry(id: string | undefined) {
</template>
</DockEntriesWithCategories>
</div>
</div>
<div class="min-h-0 flex">
</nav>
<main class="min-h-0 flex">
<DockGroupSidebar
v-if="activeGroup"
:context
Expand All @@ -95,7 +96,7 @@ function switchEntry(id: string | undefined) {
/>
<div id="devframes-views-container" ref="viewsContainer" class="pointer-events-auto" />
</div>
</div>
</main>
</div>
<FloatingElements />
<CommandPalette :context />
Expand Down
4 changes: 4 additions & 0 deletions packages/hub-ui/src/client/components/views/ViewIframe.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { stripRemoteConnectionFromUrl, watchFrameLocation } from '@devframes/hub
import { DEVFRAME_REMOTE_ASSETS_ERROR_MESSAGE_TYPE } from '@devframes/hub/constants'
import { computed, nextTick, onMounted, onUnmounted, ref, useTemplateRef, watchEffect } from 'vue'
import { t } from '../../i18n'
import { localizeTitle } from '../../state/locale'
import { useSettings } from '../../state/settings-defaults'
import ViewAssetsError from './ViewAssetsError.vue'
import ViewIframeLoading from './ViewIframeLoading.vue'
Expand Down Expand Up @@ -233,6 +234,9 @@ onMounted(() => {
style: { boxShadow: 'none', outline: 'none' },
})
const iframe = pane.iframe
watchEffect(() => {
iframe.title = localizeTitle(props.entry).title
})

// Follow the frame wherever it goes: a document load, but also an SPA
// router's `pushState`/`replaceState` and back/forward, none of which fire
Expand Down
Loading