Repository navigation
Bump crates & toolchain - #237
Merged
Merged
Conversation
blind-oracle
commented
Nov 9, 2026
Collaborator
- Rust 1.99.1
- Also upgrade repro-env
- Fix Clippy warns
|
✅ No security or compliance issues detected. Reviewed everything up to cb9c322. Security OverviewDetected Code Changes
|
There was a problem hiding this comment.
🔵 Needs a closer look
Major-version dependency upgrades and the refreshed native musl/LLVM environment require feature-matrix and reproducible-build CI validation to establish compatibility beyond this dependency-free snapshot.
No open issues 🎉
What changed in this PR
Updates the gateway’s Rust toolchain, dependencies, and reproducible build environment, with Clippy compatibility changes.
Changes:
- Bumps Rust to 1.99.1 and repro-env to 0.4.6, refreshing build-environment pins.
- Upgrades crate dependencies, including
ic-http-certificationto v4, and removes the directmaxminddbdependency. - Replaces unnecessary
format!calls with string literals and adds lint allowances forderive-newoutput.
| File | Description |
|---|---|
| tests/helpers.rs | Adds the redundant_field_names lint allowance. |
| src/routing/middleware/denylist.rs | Simplifies denylist metric strings. |
| src/routing/ic/routing_table_manager.rs | Simplifies routing-table metric strings. |
| src/routing/ic/route_provider/routes.rs | Simplifies active-node metric strings. |
| src/routing/ic/route_provider/provider.rs | Simplifies node-selection metric strings. |
| src/routing/ic/route_provider/health.rs | Simplifies health-check metric strings. |
| src/routing/ic/route_provider/fetcher.rs | Simplifies node-fetching metric strings. |
| src/routing/domain.rs | Simplifies custom-domain metric strings. |
| src/metrics/runner.rs | Simplifies memory metric strings. |
| src/metrics/mod.rs | Simplifies HTTP metric strings. |
| src/main.rs | Adds the binary’s lint allowance. |
| src/lib.rs | Adds the library’s lint allowance. |
| rust-toolchain.toml | Pins Rust to 1.99.1. |
| repro-env.lock | Refreshes the container and system-package pins. |
| Cargo.toml | Updates certification dependencies and removes direct maxminddb. |
| Cargo.lock | Refreshes resolved crate versions and dependencies. |
| .github/workflows/test.yml | Updates repro-env and its checksum for tests. |
| .github/workflows/build.yml | Updates repro-env and its checksum for builds. |
Review effort: Balanced
r-birkner
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.