Repository navigation
Fix array inputs and truth lines for one-dimensional plots - #346
Open
mikamikasuki wants to merge 1 commit into
Open
mikamikasuki wants to merge 1 commit into
mikamikasuki wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-dimensional plots currently fail in two supported paths: flat NumPy samples are indexed with three dimensions in the ArviZ adapter, and
truthsoroverplot_linestries to index a scalarAxesas an array.Reshape flat samples to
(1, n_samples, 1)and normalize the axes array locally inoverplot_lines. Add 16 regressions covering flat and column samples, reversed plots, omitted lines, line styling, truths, and caller-provided figures.Validation: all 16 regressions and pre-commit hooks pass. Independent comparisons preserve the line artists for 12 multidimensional cases and match flat, column, and three-dimensional input representations in 8 one-dimensional cases. The full suite has the same 29 image-comparison failures on the base and patched commits in this macOS environment (Matplotlib 3.11.2); the remaining results improve from 35 passed / 1 skipped to 51 passed / 1 skipped.
Fixes #300.
Fixes #285.
Prepared with AI assistance.