Skip to content

test(corpus): record the installed corpus as 0.9.1 reads it, and take minimatch 11 for the lint - #285

Merged
dgesteves merged 3 commits into
mainfrom
chore/corpus-minimatch-2026-11-16
Nov 16, 2026
Merged

dgesteves merged 3 commits into
mainfrom
chore/corpus-minimatch-2026-11-16

Conversation

@dgesteves

@dgesteves dgesteves commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Two small fixes: the weekly installed-types corpus job fails on main, and Dependabot alert #19 (minimatch) is open. The first commit's message says the token change shipped in 0.10.0. It was 0.9.1, as below.

The installed-types corpus: a stale snapshot, not a regression

The "Installed-types corpus" job in the Corpus workflow failed this morning on main (run 43872646986). It runs only on Mondays and on demand, never on pull requests. It has failed every Monday since 2026-10-26, with the same counts each time: on 10-26 at ceb2761, and on 11-02 and 11-09 at 6425861, before either dependency sweep. The run at 11:32 today that passed was the daily "Real-world corpus" job; the installed job was skipped in it. The last time the installed job passed was 2026-10-19.

I fetched and installed the corpus locally (node scripts/corpus.mjs fetch --installed, the job's own steps) and ran node scripts/corpus.mjs --installed with each commit's own build:

Commit Result
0709e58, the parent of ee231a8 passes: the counts match corpus/snapshot-installed.json
ee231a8 "fix(tokens): read wrapped theme colors, import order, the v3 radius scale and an app's own stylesheet" fails, with the same output as the failing runs
6425861, main before #278 the same output
d00ccad, main now the same output, line for line the same as run 43872646986 apart from timings

So the dependency updates in #278 and #284 (postcss, tsdown and rolldown, tailwindcss) change nothing here. ee231a8 changed what onsystem reads on purpose, with a changeset, and shipped in 0.9.1 on 2026-10-23. It regenerated corpus/snapshot.json but not corpus/snapshot-installed.json, which 0.7.0 wrote on 2026-10-16 and nothing has written since. For the same repositories, snapshot.json has had the new counts since ee231a8: saas-starter 32 color tokens, Dub 7 radius tokens and 47, 5 and 52 no-hardcoded-radius warnings.

The new counts are right:

  • Dub is on Tailwind 3 (tailwindcss ^3.4.4), and packages/tailwind-config/tailwind.config.ts sets no borderRadius, so its classes use Tailwind's default radius scale. Before 0.9.1, onsystem read no radius scale for a v3 config like this, so it had no radius tokens and reported no radius. Now it reads the 7 default steps (sm 0.125rem to 3xl 1.5rem), and an arbitrary radius off that scale is a warning, as the 0.9.1 release notes say: "In a v3 project with no radius tokens of its own, no-hardcoded-radius now runs against that scale, so check can report warnings it did not before." Three of the new findings, at Dub's pinned commit 70c96f9:

    • apps/web/ui/partners/lander/lander-rewards.tsx:58: "rounded-[10px] border border-neutral-200 bg-neutral-50 px-5 py-4". Hardcoded radius rounded-[10px] (10px) is off the scale. Nearest: rounded-lg (8px).
    • apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-rewards.tsx:162: <div className="flex flex-col gap-2 rounded-[10px] border border-neutral-200 bg-white p-3">. The same finding.
    • packages/ui/src/nav/content/resources-content.tsx:29: className="grid grid-cols-3 divide-x divide-neutral-200 rounded-b-[20px] bg-white …". Hardcoded radius rounded-b-[20px] (20px) is off the scale. Nearest: rounded-b-2xl (16px).

    Each is a radius that Tailwind's scale doesn't have, reported as a warning. That's the rule's job.

  • saas-starter's app/globals.css has the @theme { --color-background: hsl(var(--background)); … } block that shadcn/ui's Tailwind 4 codemod leaves. Since ee231a8, a theme color that wraps a variable of bare channels in hsl() is an alias of that variable. I compared inspect --format json before and after ee231a8: the 8 color tokens that leave are color-sidebar (hsl(var(--sidebar-background))) and the other seven color-sidebar-* entries. Each is now an alias of the --sidebar-* variable it wraps, which is a token already. That takes 40 color tokens to 32, and its findings don't change.

So I updated the snapshot with node scripts/corpus.mjs --installed --update at d00ccad. The diff is exactly the rows the job printed, plus version (0.7.0 to 0.12.1):

Run Change
saas-starter-installed color tokens 40 → 32
dub-web-installed radius tokens 0 → 7, flagged files 1,009 → 1,011, no-hardcoded-radius 0 → 47 warnings (47 fixable)
dub-ui-installed radius tokens 0 → 7, no-hardcoded-radius 0 → 5 warnings (5 fixable)
dub-web-configured-installed radius tokens 0 → 7, flagged files 989 → 991, no-hardcoded-radius 0 → 47 warnings (47 fixable)
dub-root-installed radius tokens 0 → 7 in apps/web and packages/ui, flagged files 1,029 → 1,031, no-hardcoded-radius 0 → 52 warnings (52 fixable)

Run again after the update, node scripts/corpus.mjs --installed passes, and the installed holdout still reports all 109 of its findings. No source changes and no changeset: users have had this behaviour since 0.9.1, and only the record of it was behind.

bench/v2/config/repos.json and bench/v2/README.md still describe saas-starter as having "40 color tokens". That was the count when the benchmark ran, and those strings are part of its published task inputs and results, so I left them.

minimatch 11 for the lint (alert #19)

GHSA-g3hv-75wg-m249 (moderate, dev scope): minimatch 7 to 11.0.0 amplifies patterns with **/.. portions, and only 11.0.1 fixes it. minimatch 10.2.6 comes in through ESLint 10.12 and its @eslint/config-array 0.23.5, and through typescript-eslint's @typescript-eslint/typescript-estree 8.72.2. All three ask for ^10. ESLint 10.15.0 and config-array 0.23.6 (from 2026-11-13) move to ^11.0.5, but typescript-estree 8.72.2, the newest, still asks for ^10.2.2, so a bump alone doesn't fix it. ESLint 9 (the eslint-v9 alias) and eslint-plugin-jsx-a11y use minimatch 3.1.5, which the advisory doesn't list. The published package doesn't depend on minimatch.

So pnpm-workspace.yaml gets the override ondocs uses. Its comment says why it's safe and when to take it out: once the lockfile has ESLint 10.15 and typescript-eslint asks for 11.

'minimatch@>=7 <11.0.1': ^11.0.1

It resolves to 11.0.8 (with its new dependency @isaacs/nonrecursive-glob-match 1.1.0). minimatch 11 removes makeRe(), Minimatch#regexp, the AST class and a few internal methods. ESLint and config-array use new Minimatch(), match() (with partial) and pattern. typescript-estree calls minimatch() only for allowDefaultProject, which neither ESLint config here sets. All of those stay in 11, which ships CommonJS as well, for ESLint's require. To check, I ran ESLint with --format json before and after, for the root (215 files) and the site (135 files), and compared every file's errors, warnings and messages: they're identical.

minimumReleaseAgeExclude also loses its entries for typescript-eslint 8.71.1 (11 packages) and ondocs 0.10.0. None of those versions is in the lockfile any more. The 7 Radix entries stay, because those versions still are.

Audit

  • pnpm audit: no known vulnerabilities (1 moderate on main, this minimatch).

Checks

On a clean node_modules, with the new lockfile:

  • pnpm install --frozen-lockfile: pass, and the lockfile passes pnpm's supply-chain checks (minimatch 11.0.8 is from 2026-11-11)
  • pnpm lint, pnpm format:check, pnpm typecheck, and pnpm --filter "./examples/*" typecheck: pass
  • pnpm build: pass; schema.json unchanged
  • pnpm smoke, the dogfood check of app/settings/members.tsx, and the Claude Code hook on app/settings/danger-zone.tsx (exit code 2, no-unknown-variant): pass
  • pnpm test: 115 files pass and 1 is skipped; 1,500 tests pass and 3 are skipped
  • pnpm test:coverage: pass (lines 95.74%, branches 87.46%, functions 95.69%, statements 93.59%)
  • pnpm pack-test: pass, including the ESLint 8.57.0 project
  • Site: generate, test (295 tests), typecheck, lint and build: pass
  • node scripts/corpus.mjs --installed: passes with the new snapshot

The installed job is skipped on pull requests, so I dispatched the Corpus workflow on this branch: in run 43879601491, both the installed-types and the real-world corpus pass.

dgesteves and others added 3 commits November 16, 2026 13:40
The weekly installed-types corpus job has failed every Monday since
2026-10-26 with the same counts. ee231a8 (in 0.10.0) changed what
onsystem reads, regenerated corpus/snapshot.json, and left
corpus/snapshot-installed.json as 0.7.0 wrote it, since the installed
job does not run on pull requests. Run at ee231a8's parent, the
installed corpus matches the old snapshot; at ee231a8, at 6425861 and
at d00ccad it gives the same counts as the failing runs.

The new counts are the ones snapshot.json has had since ee231a8 for the
same repositories:

- Dub (Tailwind 3, no borderRadius in its config) gets Tailwind's
  default radius scale, 7 tokens, so off-scale radii such as
  rounded-[10px] are reported as warnings: 47 in apps/web, 5 in
  packages/ui, 52 from the root.
- saas-starter has 32 color tokens instead of 40: the codemod's
  `@theme { --color-x: hsl(var(--x)) }` entries are now aliases of the
  variables they wrap.

Written with `node scripts/corpus.mjs --installed --update` at d00ccad.
…age exclusions

Dependabot alert #19, GHSA-g3hv-75wg-m249 (moderate, dev): minimatch 7
to 11.0.0 amplifies patterns with **/.. portions, and only 11.0.1 fixes
it. ESLint 10, its @eslint/config-array and typescript-eslint's
typescript-estree ask for ^10, so an override in pnpm-workspace.yaml
takes 11.0.8, with a comment on why it is safe and when to remove it.
They use minimatch(), new Minimatch(), match() and pattern, which 11
keeps. ESLint reports the same, file for file, for the root and the
site with it. ESLint 9's minimatch 3 is outside the advisory.

minimumReleaseAgeExclude loses the entries for typescript-eslint 8.71.1
and ondocs 0.10.0, which are no longer in the lockfile. The Radix
entries stay: those versions still are.
@dgesteves
dgesteves merged commit 3390a64 into main Nov 16, 2026
21 checks passed
@dgesteves
dgesteves deleted the chore/corpus-minimatch-2026-11-16 branch November 16, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant