Repository navigation
Merge develop to main - #1345
Merged
Merged
Conversation
- Create the new DeliverableId class - Add GetApplicableRoles() - Refactor comment
Allow adjuncts to be access controlled
Implement adjunct probe service
…ts when building a manifest
Note that RFC 25 is skipped as there is an open PR for this
* Added DeliverableId to IAccessControlledOrchestrationItem which allows changes to various interfaces to accept single object rather than separate Id and Roles. This also removes possibility for these to get out of sync and keeps the BaseAssetRequest only responsible for parsing paths only. * Moved ProbeServiceSupport out of .Requests namespace
Summary of changes: * Assets and Adjuncts are gathered into single list, this makes next steps simpler. * Log count of all items being fetched, not just Assets * Use Parallel.ForEach() with a configurable MaxDegreeOfParallelism, removing the ContinueWith(), separate Adjunct handling and need to wait on all Asset requests to finish before making any Adjunct.
Return non-nullable dict as we always instantiate eventually.
Introducing new one gives 2 sources of truth for same logic
Enable adjunct probe service to be output on a manifest
Also removed open questions
RFC for controlling filename for image download
Download image
This is really bumping iiif-net nuget and adding tests. Note that this is using a pre-release iiif-net, will need to update when full release is cut Nuget package now prevents 0 sizes so this is dropped from IsCandidateForImageHandling.
Improve invalid imageRequest handling
* Logic only checked for null open thumbs, not handling empty return value, which is the common return type for 'found but empty' s.json * Handle s.json listing a size but matching thumb isn't found. The assumption is that this can't happen but there have been legacy images from 2021 where this is the case. Was a cheap check to add. * Expanded tests for thumb handling
Handle empty open thumbs for images
Co-authored-by: donaldgray <[email protected]>
Add Vary:Accept header to thumbs responses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard merge ahead of release.