Skip to content

Merge develop to main - #1345

Merged
donaldgray merged 40 commits into
mainfrom
develop
Nov 2, 2026
Merged

donaldgray merged 40 commits into
mainfrom
develop

Conversation

@donaldgray

Copy link
Copy Markdown
Member

Standard merge ahead of release.

JackLewis-digirati and others added 30 commits October 7, 2026 14:10
- Create the new DeliverableId class
- Add GetApplicableRoles()
- Refactor comment
Note that RFC 25 is skipped as there is an open PR for this
* Added DeliverableId to IAccessControlledOrchestrationItem which allows
changes to various interfaces to accept single object rather than
separate Id and Roles. This also removes possibility for these to get
out of sync and keeps the BaseAssetRequest only responsible for parsing
paths only.
* Moved ProbeServiceSupport out of .Requests namespace
Summary of changes:
* Assets and Adjuncts are gathered into single list, this makes next
steps simpler.
* Log count of all items being fetched, not just Assets
* Use Parallel.ForEach() with a configurable MaxDegreeOfParallelism,
removing the ContinueWith(), separate Adjunct handling and need to wait
on all Asset requests to finish before making any Adjunct.
Return non-nullable dict as we always instantiate eventually.
Introducing new one gives 2 sources of truth for same logic
Enable adjunct probe service to be output on a manifest
RFC for controlling filename for image download
This is really bumping iiif-net nuget and adding tests.
Note that this is using a pre-release iiif-net, will need to update
when full release is cut

Nuget package now prevents 0 sizes so this is dropped from
IsCandidateForImageHandling.
donaldgray and others added 10 commits October 14, 2026 13:37
Improve invalid imageRequest handling
* Logic only checked for null open thumbs, not handling empty return
value, which is the common return type for 'found but empty' s.json
* Handle s.json listing a size but matching thumb isn't found. The
assumption is that this can't happen but there have been legacy images
from 2021 where this is the case. Was a cheap check to add.
* Expanded tests for thumb handling
Handle empty open thumbs for images
Add Vary:Accept header to thumbs responses
@donaldgray
donaldgray requested a review from a team as a code owner November 2, 2026 16:17
@donaldgray
donaldgray merged commit 13a8889 into main Nov 2, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants